Differential D34344

libc: iconv: add mb_cur_min for encoder traits
ClosedPublic
Actions

Authored by kevans on Feb 22 2022, 5:25 PM.

Project Tags

None

Referenced Files

None

Subscribers

imp

thj

Details

Reviewers

jrtc27
emaste

Group Reviewers

Klara

Commits

rG2300a22c9712: libc: iconv: add mb_cur_min for encoder traits

Summary

A future commit will actually implement //IGNORE so that applications
using base iconv can, e.g., sanitize UTF-8 strings. To do this, the
iconv_std module needs to be able to determine the minimum width for any
given encoding so that it can skip that many bytes in the input buffer.
This is mainly an issue for UTF-16 and UTF-32.

This commit bumps shlib versions to 5 for libiconv modules to reflect
the ABI change. It also fixes OptionalObsoleteFiles to remove the
libiconv modules if WITHOUT_ICONV is in use.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44537
Build 41425: arc lint + arc unit

Event Timeline

kevans created this revision.Feb 22 2022, 5:25 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2022, 5:25 PM

kevans requested review of this revision.Feb 22 2022, 5:25 PM

Harbormaster completed remote builds in B44537: Diff 103111.Feb 22 2022, 5:25 PM

kevans added a parent revision: D34343: libc: iconv: push option ignore into citrus_iconv_open().Feb 22 2022, 5:25 PM

kevans added a child revision: D34345: iconv_std: complete the //IGNORE support.

thj subscribed.Aug 2 2022, 12:19 PM

thj added inline comments.

lib/libc/iconv/citrus_stdenc_template.h
54	I can't track down the resolution of encoding info. This define always being one seems to exclude the 'otherwise specified' part of the comment, is the minimum changed somewhere else?

kevans added inline comments.Aug 2 2022, 2:07 PM

lib/libc/iconv/citrus_stdenc_template.h
54	These are all kind of whacky, but this file is actually part of the module template and only gets #include'd at the bottom of a module.c, so the module is free to #define it and we'll use that instead below. The below methods are declared in the module's .h, which is what libiconv uses.