Page MenuHomeFreeBSD
Differential D27893

hid: Import usbhid - USB transport backend for HID subsystem
ClosedPublic
Actions

Authored by wulf on Jan 2 2021, 12:31 PM.
Tags
None
Referenced Files
F157374014: D27893.id81849.diff
Wed, May 20, 6:18 PM
Unknown Object (File)
Mon, May 18, 7:57 AM
Unknown Object (File)
Mon, May 18, 7:57 AM
Unknown Object (File)
Mon, May 18, 7:57 AM
Unknown Object (File)
Mon, May 18, 7:56 AM
Unknown Object (File)
Sun, May 17, 6:18 PM
Unknown Object (File)
Sun, May 17, 6:10 PM
Unknown Object (File)
Mon, May 11, 6:18 AM
View All Files
Subscribers
None

Details

Reviewers
imp
avg
• hselasky
markj
val_packett.cool
manu
Commits
rGa898ee51c41d: Fix LINT kernel build after 01f2e864f79584c0cd250a8e7cfb501a9985768a.
rG01f2e864f795: hid: Import usbhid - USB transport backend for HID subsystem.
Summary

This implements hid_if.m methods for HID-over-USB protocol [1].

Also, this adds USBHID_ENABLED kernel option which changes device_probe()
priority and adds/removes PnP records to prefer usbhid over ums, ukbd, wmt
and other USB HID device drivers.

The module is based on uhid(4) driver.

It is disabled by default for now due to conflicts with existing USB HID drivers.

[1] https://www.usb.org/sites/default/files/hid1_11.pdf

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf requested review of this revision.Jan 2 2021, 12:31 PM
wulf created this revision.
• hselasky added inline comments.Jan 2 2021, 1:00 PM
sys/dev/usb/input/usbhid.c
162

I think this usbd_transfer_stop(xfer) is superfluous.

wulf updated this revision to Diff 81577.Jan 3 2021, 11:03 AM
wulf marked an inline comment as done.
wulf added inline comments.
sys/dev/usb/input/usbhid.c
162

usbd_transfer_stop(xfer) moved to usbhid_intr_stop() routine and replaced with usbd_transfer_drain()

• hselasky accepted this revision.Jan 4 2021, 10:10 AM
This revision is now accepted and ready to land.Jan 4 2021, 10:10 AM
Closed by commit rG01f2e864f795: hid: Import usbhid - USB transport backend for HID subsystem. (authored by wulf). · Explain WhyJan 7 2021, 11:22 PM
This revision was automatically updated to reflect the committed changes.
wulf marked an inline comment as done.
wulf added a commit: rG01f2e864f795: hid: Import usbhid - USB transport backend for HID subsystem..
• hselasky added a commit: rGa898ee51c41d: Fix LINT kernel build after 01f2e864f79584c0cd250a8e7cfb501a9985768a..Jan 9 2021, 10:03 AM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
1 line
79 lines
sys/
amd64/
conf/
3 lines
conf/
1 line
1 line
dev/
hid/
1 line
usb/
input/
2 lines
2 lines
2 lines
786 lines
4 lines
i386/
conf/
3 lines
modules/
usb/
3 lines
usbhid/
10 lines

Diff 81849

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/usbhid.4

Loading...
View Options

sys/amd64/conf/GENERIC

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/conf/options

Loading...
View Options

sys/dev/hid/hidbus.c

Loading...
View Options

sys/dev/usb/input/uhid.c

Loading...
View Options

sys/dev/usb/input/ukbd.c

Loading...
View Options

sys/dev/usb/input/ums.c

Loading...
View Options

sys/dev/usb/input/usbhid.c

Loading...
View Options

sys/dev/usb/input/wmt.c

Loading...
View Options

sys/i386/conf/GENERIC

Loading...
View Options

sys/modules/usb/Makefile

Loading...
View Options

sys/modules/usb/usbhid/Makefile

Loading...