- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 23 2025
Fix a pre-existing typo in the manual's synopsis (s/x/w/).
update from rebase
Apply @markj comments.
Thank you for working on this! Can we add tests here?
In D49391#1127890, @markj wrote:The functional portion of the change seems fine, but I'm not sure why it's a problem for vm_page_grab* to support VM_ALLOC_WAITFAIL?
In D49440#1127936, @mjg wrote:can you instead sort the files and require the ordering that smaller is addr is locked first? a dedicated routine could do it
this would also avoid failures to lock to begin with
can you instead sort the files and require the ordering that smaller is addr is locked first? a dedicated routine could do it
Looks fine to me.
Looks fine to me, rick
Use a dedicated flag variable to track foffset locking.
Add part of the commit message into the comment.
Thanks for your review, Mark! I'll get to fixing the issues you highlighted soon.
The functional portion of the change seems fine, but I'm not sure why it's a problem for vm_page_grab* to support VM_ALLOC_WAITFAIL?
Move the comment.
foffset_lock1() has local scope.
Apply Gleb's suggestion.
In D49447#1127828, @zlei wrote:Do I understand it right that the goal is for the output path to stop "seeing" an interface that is being detached earlier?
Yes. In D49359 I commented