ktrace: Use STAILQ_EMPTY_ATOMIC when checking for records in userret()
ClosedPublic
Actions

Authored by markj on Mar 21 2025, 2:09 PM.

Details

Reviewers

Commits

rG51489b9ced27: ktrace: Use STAILQ_EMPTY_ATOMIC when checking for records in userret()
rGe9a846468acf: ktrace: Use STAILQ_EMPTY_ATOMIC when checking for records in userret()

Summary

As in commit 36631977d8c9, this check is unlocked and may trigger
spurious assertion failures. Use STAILQ_EMPTY_ATOMIC() here as well.
Fix nearby whitespace.

Reported by: syzkaller
Fixes: 34740937f7a4 ("queue: New debug macros for STAILQ")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 21 2025, 2:09 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 21 2025, 2:09 PM

markj requested review of this revision.Mar 21 2025, 2:09 PM

Harbormaster completed remote builds in B63027: Diff 152499.Mar 21 2025, 2:09 PM

olce accepted this revision.Mar 21 2025, 5:36 PM

This revision is now accepted and ready to land.Mar 21 2025, 5:36 PM

Closed by commit rGe9a846468acf: ktrace: Use STAILQ_EMPTY_ATOMIC when checking for records in userret() (authored by markj). · Explain WhyMar 23 2025, 12:00 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGe9a846468acf: ktrace: Use STAILQ_EMPTY_ATOMIC when checking for records in userret().

markj added a commit: rG51489b9ced27: ktrace: Use STAILQ_EMPTY_ATOMIC when checking for records in userret().Apr 6 2025, 10:51 PM

Revision Contents
Changeset List

Path

Size

sys/

ktrace.h

5 lines

Diff 152554

View Options

ktrace: Use STAILQ_EMPTY_ATOMIC when checking for records in userret()ClosedPublicActions