top: Polish key bindings in usage and manual

[ziaee]

Summary

Organize key bindings by ascii(7) for consistency and maintainability,
mark them as Interactive Commands, wordsmith them, and sync their
organization between the manual and
help screen.

MFC after: 3 days
PR: 282734
Fixes: c8aa5e526 (move command mapping to commands.c)

[ziaee]

Fix a pre-existing typo in the manual's synopsis (s/x/w/).

[jpb_jimby.name]

usr.bin/top/top.1

270

Consider adding a note here about some options that toggle their effect such as 'i' showing / not showing idle processes. There are a number of such options.

272–273

Consider moving this note to the '/' command. There are similar notes in other commands (see 'J', 'p', and 'u').

[ziaee]

I have been working on this manual for many hours over the last two
days. This commit is just scoped to this section. Subsequent patches
to follow.

[ziaee]

usr.bin/top/top.1

272–273

You're right, my mistake copying.

[ziaee]

Fix a small consistency nit

[ziaee]

Fix a grammatical typo, I think this is the last one.

[mhorne]

FYI, it is difficult to review a change that reorders and rewords a list of entries, at the same time. In the future such a thing should be split.

However, seems good to me.

[imp]

Same comments a mhorne

[ziaee]

Thanks!

[ziaee]

*sigh* and after all that I still messed it up.
In this situation, we have:

1. The help screen
2. The usage
3. The manual synopsis
4. The manual description (just the command explanations, the introductiory paragraph is also wrong, but trying to scope)

Every single one of them disagrees in different ways with what the program does. I will send another patch tonight. Sorry everyone. At least this is substantially more accurate than what we had before.

usr.bin/top/commands.c

iwn_vap_create(struct ieee80211com *ic, const char name[IFNAMSIZ], int unit,
         vap = &ivp->iv_vap;
         ieee80211_vap_setup(ic, vap, name, unit, opmode, flags, bssid);
         ivp->ctx = IWN_RXON_BSS_CTX;
         vap->iv_bmissthreshold = 10;                /* override default */
         /* Override with driver methods. */
         ivp->iv_newstate = vap->iv_newstate;
         vap->iv_newstate = iwn_newstate;
         sc->ivap[IWN_RXON_BSS_CTX] = vap;
+        vap->iv_ampdu_rxmax = IEEE80211_HTCAP_MAXRXAMPDU_64K;
+        vap->iv_ampdu_density = IEEE80211_HTCAP_MPDUDENSITY_4; /* 4uS */
 
         ieee80211_ratectl_init(vap);
         /* Complete setup. */
         ieee80211_vap_attach(vap, iwn_media_change, ieee80211_media_status,
             mac);
         ic->ic_opmode = opmode;
         return vap;
 }

usr.bin/top/top.1

iwn_vap_create(struct ieee80211com *ic, const char name[IFNAMSIZ], int unit,
         vap = &ivp->iv_vap;
         ieee80211_vap_setup(ic, vap, name, unit, opmode, flags, bssid);
         ivp->ctx = IWN_RXON_BSS_CTX;
         vap->iv_bmissthreshold = 10;                /* override default */
         /* Override with driver methods. */
         ivp->iv_newstate = vap->iv_newstate;
         vap->iv_newstate = iwn_newstate;
         sc->ivap[IWN_RXON_BSS_CTX] = vap;
+        vap->iv_ampdu_rxmax = IEEE80211_HTCAP_MAXRXAMPDU_64K;
+        vap->iv_ampdu_density = IEEE80211_HTCAP_MPDUDENSITY_4; /* 4uS */
 
         ieee80211_ratectl_init(vap);
         /* Complete setup. */
         ieee80211_vap_attach(vap, iwn_media_change, ieee80211_media_status,
             mac);
         ic->ic_opmode = opmode;
         return vap;
 }