Approved By: allanjude

Reviewed By: allanjude

Other than fixing the links, looks good to me.

We should make the -M flag be compile time dependant in WITH_STATS

Thank you very much for making this work.

Approved By: allanjude

Approved By: allanjude

Approved By: allanjude (mentor)

This makes sense. It is not clear how many upstream projects will adopt this license, so this seem like the right first step.

I might reverse the order of these, since loading the module is the recommended action, and compiling it into your kernel is for people who want to do custom kernels.

In D20477#443980, @cem wrote:

So like, what's the motivation of this change? What are the goals? How was this design chosen? There's 6000 lines of diff present as a fait accompli without any kind of socialization on arch@ or anywhere else. Code is great, but the high level stuff is missing.

Comment density is "low" and copy-paste density is "high." Did you consider templating this, either with awk or C++?

"stats(3)" is a bit misleading; 3900 LoC are a new kernel file. What is the expected consumer? What is the general API surface? Where is the design doc?

Where is the stats(9) manual page? What do stats(3) consumers look like? Will there ever be any in tree? Can this live in ports?

Approved By: allanjude (mentor)

@rgrimes If you want to commandeer this review and put an updated diff, that would be great.

This is a nice cleanup, thank you.

Send it

Approved

Remove the duplicated event (Pedro Giffuni commit bit enhanced)

The description does not seem to match what the code does now.

Need to add opt_tmpfs.h to the tmpfs kernel module Makefile

In D19686#421604, @delphij wrote:

Why is the partition index changed from 1 to 2? (The change looks otherwise fine to me).

Sorry to arrive so late to this review.

I'd also like to see someone else's opinion on making whitespace changes.

Seems like a good fix, and even an optimization.

Focus on non-developers