Address the last of dteske's feedback
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 23 2018
Aug 23 2018
Aug 22 2018
Aug 22 2018
allanjude updated the diff for D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
allanjude added reviewers for D12507: Dummynet AQM usage documentation for ipfw man page: rgrimes, ae.
Fix comment style
Fix a minor error
Update with latest feedback
allanjude updated the diff for D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Address the rest of the feedback from emaste and dteske
allanjude added inline comments to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
allanjude updated the diff for D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Updated to use loader.efi and create a startup.nsh
Aug 21 2018
Aug 21 2018
Aug 20 2018
Aug 20 2018
+1 this patch, has caught me out a number of times.
In D16684#355335, @mandree wrote:Thanks. This is looking almost good, just the error handling for the close() and we should be done. I haven't been able to do run-time testing yet.
Again, the downloaded diff does not apply - what's wrong here?
-------------------------- |Index: security/ca_root_nss/files/MAca-bundle.pl.in |=================================================================== |--- security/ca_root_nss/files/MAca-bundle.pl.in |+++ security/ca_root_nss/files/MAca-bundle.pl.in -------------------------- Patching file files/MAca-bundle.pl.in using Plan A... Hunk #1 succeeded at 1. Hunk #2 failed at 36. Hunk #3 succeeded at 92. Hunk #4 succeeded at 121. Hunk #5 succeeded at 188. 1 out of 5 hunks failed while patching files/MAca-bundle.pl.in done
Aug 14 2018
Aug 14 2018
Update with feedback from mandree
Aug 12 2018
Aug 12 2018
Approved By: allanjude
Approved By: allanjude
Aug 11 2018
Aug 11 2018
Approved By: allanjude
I think an example of entities in use may be helpful here.
Approved By: allanjude
Approved By: allanjude
Approved By: allanjude
Approved by mentor once it is approved by des or other openssh maintainer.
Aug 7 2018
Aug 7 2018
allanjude added reviewers for D16613: Backport OpenBSD's pf Revision 1.1017 fixes to FreeBSD: kp, glebius.
Aug 6 2018
Aug 6 2018
Aug 1 2018
Aug 1 2018
In D10320#351215, @emaste wrote:I still believe this change should go in, although if we really believe it's a backwards compatibility issue perhaps avoid default only with -n -n or -nn?
Jul 27 2018
Jul 27 2018
allanjude added reviewers for D15713: Bug 182518 - [login.conf] Better Password Hashes : delphij, jmg.
Approved By: allanjude
Jul 24 2018
Jul 24 2018
ZFS: Reserve DMU_BACKUP_FEATURE flags for Native Encryption and ZSTD
Jul 22 2018
Jul 22 2018
Approved By: allanjude
Jul 21 2018
Jul 21 2018
Once Warner or someone else with build clue signs off
allanjude accepted D16373: Purge some old apmd files since it is not connected to the build anymore.
Approved By: allanjude
Jul 20 2018
Jul 20 2018
allanjude accepted D16361: Stop building zfsloader. Instead, include zfs in loader. Provide a compatibility link from zfsloader to loader for people that haven't updated their boot blocks..
Looks right to me
Jul 18 2018
Jul 18 2018
Approved By: allanjude
Approved By: allanjude
allanjude retitled D11841: Installer support for Desktop Environments from Mk/Scripts/qa.sh : Installer support for Desktop Environments to Installer support for Desktop Environments.
This is the correct diff
This diff got overwritten with the wrong content
It would only make sense to give each site a <para> like it was before, if we had an entire paragraph about each side. We don't, so I think the shorter list is much better.
Approved By: allanjude
Jul 16 2018
Jul 16 2018
Make ZSTD compile in if you enable ZFS
Jul 15 2018
Jul 15 2018
Update patch to r336271 and add ZSTD-Fast modes
Approved by: allanjude
Jul 14 2018
Jul 14 2018
It likely should have a way to indicate which parameters are optional
Approved By: allanjude
Jul 11 2018
Jul 11 2018
Don't forget you still need your Mentor's approval
Jul 8 2018
Jul 8 2018
Jul 7 2018
Jul 7 2018
Jul 6 2018
Jul 6 2018
Jul 5 2018
Jul 5 2018
Colin specifically asked me about this feature at BSDCan, so has therefore volunteered to help test it.
Jul 4 2018
Jul 4 2018
Approved
Approved
allanjude added reviewers for D12507: Dummynet AQM usage documentation for ipfw man page: allanjude, bcr.
Jul 3 2018
Jul 3 2018
stand/common/disk.c: dev->d_offset still needs to be set to 0
Jul 2 2018
Jul 2 2018
allanjude committed rS335868: stand/common/disk.c: Read partition table relative to the start of the disk.
stand/common/disk.c: Read partition table relative to the start of the disk
Jun 30 2018
Jun 30 2018
Jun 29 2018
Jun 29 2018
Jun 28 2018
Jun 28 2018
I'll update the zstd-zfs patch to deal with this once it lands, it shouldn't be an issue.
Jun 25 2018
Jun 25 2018
ping
Jun 21 2018
Jun 21 2018
Jun 20 2018
Jun 20 2018
Thank you for fixing up this document, it really needed it.
Jun 19 2018
Jun 19 2018
In D15801#334441, @eadler wrote:What do y'all think of making the username the maximum length username seen so far (up until a fixed max). This solves all known issues
- having to short username
- having too long username
- initialization being slow since it needs to iterate over a remote service
- having the column flicker due to a long username going in and out of use.
Jun 18 2018
Jun 18 2018
Jun 17 2018
Jun 17 2018
allanjude added a comment to D15844: Avoid reading past the end of the disk in zfsboot.c and biosdisk.c.
In D15844#335494, @ian wrote:Do we have any idea what led to attemping to read past the end? If it happens only during tasting, that's probably because the current logic/code for tasting is a bit suspect in how it decides which sectors to try, in which case, that's what should be fixed. If it happens during normal filesystem IO then something odd is going on that we should understand better.
allanjude updated the diff for D15847: stand/common/disk.c: Read the partition table relative to the start of the drive.
Update with a much more satisfying fix, as suggested by @ian
allanjude retitled D15847: stand/common/disk.c: Read the partition table relative to the start of the drive from biosdisk.c: don't attempt to decrypt content that is not encrypted to stand/common/disk.c: Read the partition table relative to the start of the drive.
stand/common/disk.c: Update debug printf
allanjude added inline comments to D15847: stand/common/disk.c: Read the partition table relative to the start of the drive.
rootgen.sh: complete all profiles except GELI+MBR (not supported)
allanjude updated the diff for D15846: rootgen.sh: complete all profiles except GELI+MBR (not supported).
amd64-geli-gpt-ufs-both: legacy: works, uefi: no geli support
amd64-geli-gpt-ufs-legacy: works
amd64-geli-gpt-ufs-uefi: no geli support
amd64-geli-gpt-zfs-both: legacy: works, uefi: no geli support
amd64-geli-gpt-zfs-legacy: works
amd64-geli-gpt-zfs-uefi: no geli support
amd64-geli-mbr-ufs-both: no geli support
amd64-geli-mbr-ufs-legacy: no geli support
amd64-geli-mbr-ufs-uefi: no geli support
amd64-geli-mbr-zfs-both: no geli support
amd64-geli-mbr-zfs-legacy: no geli support
amd64-geli-mbr-zfs-uefi: no geli support
amd64-nogeli-gpt-ufs-both: legacy: works, uefi: works
amd64-nogeli-gpt-ufs-legacy: works
amd64-nogeli-gpt-ufs-uefi: works
amd64-nogeli-gpt-zfs-both: legacy: works, uefi: works
amd64-nogeli-gpt-zfs-legacy: works
amd64-nogeli-gpt-zfs-uefi: works
amd64-nogeli-mbr-ufs-both: legacy: works, uefi: works
amd64-nogeli-mbr-ufs-legacy: works
amd64-nogeli-mbr-ufs-uefi: works
amd64-nogeli-mbr-zfs-both: legacy: works, uefi: works
amd64-nogeli-mbr-zfs-legacy: works
amd64-nogeli-mbr-zfs-uefi: works
allanjude retitled D15846: rootgen.sh: complete all profiles except GELI+MBR (not supported) from rootgen.sh: complete all profiles except GELI+MBR (not supported) and MBR+EFI/DUAL to rootgen.sh: complete all profiles except GELI+MBR (not supported).
allanjude committed rS335276: gptboot, zfsboot, gptzfsboot: Enable the video and serial consoles early.
gptboot, zfsboot, gptzfsboot: Enable the video and serial consoles early
allanjude retitled D15862: gptboot, zfsboot, gptzfsboot: Enable the video and serial consoles early from gptboot, zfsboot, gptzfsboot: Enable the serial console sooner to gptboot, zfsboot, gptzfsboot: Enable the video and serial consoles early.