Page MenuHomeFreeBSD
Differential D16386

geli attach: Fix exit codes and errors not being printed after r335673
ClosedPublic
Actions

Authored by woodsb02 on Jul 22 2018, 2:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 4 2024, 10:22 AM
Unknown Object (File)
Dec 30 2023, 11:12 PM
Unknown Object (File)
Dec 22 2023, 9:23 PM
Unknown Object (File)
Oct 19 2023, 11:29 AM
Unknown Object (File)
Oct 13 2023, 2:45 PM
Unknown Object (File)
Oct 12 2023, 10:40 PM
Unknown Object (File)
Oct 12 2023, 1:59 AM
Unknown Object (File)
Sep 21 2023, 11:18 AM
View All 18 Files
Subscribers
allanjude
imp

Details

Reviewers
sobomax
asomers
allanjude
Commits
rS336602: geli attach: Fix exit codes and errors not being printed after r335673
Summary

geli attach: Fix exit codes and errors not being printed after rS335673

Now that multiple providers can be attached at once, exit codes and
error messages must be handled correctly if there are failures in on
any of the providers.

Reporting by: asomers (Kyua continuous integration failures)

Test Plan

$ sudo kyua test -k /usr/tests/sys/geom/class/eli/Kyuafile

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

woodsb02 created this revision.Jul 22 2018, 2:14 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 22 2018, 2:14 AM
Harbormaster completed remote builds in B18241: Diff 45668.Jul 22 2018, 2:14 AM
woodsb02 edited the test plan for this revision. (Show Details)Jul 22 2018, 2:15 AM
woodsb02 edited the summary of this revision. (Show Details)
allanjude accepted this revision.Jul 22 2018, 2:45 AM
allanjude added a subscriber: allanjude.

Approved By: allanjude

This revision is now accepted and ready to land.Jul 22 2018, 2:45 AM
asomers requested changes to this revision.Jul 22 2018, 3:38 AM

Apart from style, it looks good. BTW, you should also add ATF tests for the new functionality that you added in r335673, though that needn't be part of this commit.

lib/geom/eli/geom_eli.c
945 ↗(On Diff #45668)

80 columns per line, please.

This revision now requires changes to proceed.Jul 22 2018, 3:38 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Jul 22 2018, 1:41 PM
Closed by commit rS336602: geli attach: Fix exit codes and errors not being printed after r335673 (authored by woodsb02). · Explain Why
This revision was automatically updated to reflect the committed changes.
woodsb02 added a comment.Jul 22 2018, 1:44 PM

Thanks for your review Alan and Allan!

Revision Contents
Changeset List

PathSize
head/
lib/
geom/
eli/
31 lines

Diff 45682

View Options

head/lib/geom/eli/geom_eli.c

Loading...