Page MenuHomeFreeBSD

Make ZSTD optional via options ZSTDIO.
ClosedPublic

Authored by sbruno on Jun 25 2018, 1:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 2:36 AM
Unknown Object (File)
Dec 23 2023, 2:36 AM
Unknown Object (File)
Dec 23 2023, 2:36 AM
Unknown Object (File)
Dec 23 2023, 2:36 AM
Unknown Object (File)
Dec 23 2023, 2:24 AM
Unknown Object (File)
Dec 20 2023, 4:07 AM
Unknown Object (File)
Dec 19 2023, 11:44 AM
Unknown Object (File)
Dec 11 2023, 4:44 AM
Subscribers

Details

Summary

It looks like the intent was to allow ZSTD support to be
compiled into the kernel with options ZSTDIO. But it doesn't look
like that was ever implemented or I'm missing how to do it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Doesn't it also need to be conditional on ZFS support?

Doesn't it also need to be conditional on ZFS support?

Yeah, I'm not sure TBH. I didn't want to blindly fire this into the tree without someone who knows what this stuff does give it some thought.

This could be fine. Does everything else still compile? I'd make sure the kernel dump compression DTRT w/ the option off and ZFS too. I don't know of any other kernel consumers.

Doesn't it also need to be conditional on ZFS support?

Maybe I just don't see it. What's the relationship between ZFS and ZSTD?

http://facebook.github.io/zstd/

Maybe I just don't see it. What's the relationship between ZFS and ZSTD?

ZFS supports compressing file data. One algorithm it can use is Zstd.

Edit: https://reviews.freebsd.org/D11124 — I guess it's not in OpenZFS nor FreeBSD yet.

In D16007#338923, @cem wrote:

Maybe I just don't see it. What's the relationship between ZFS and ZSTD?

ZFS supports compressing file data. One algorithm it can use is Zstd.

Edit: https://reviews.freebsd.org/D11124 — I guess it's not in OpenZFS nor FreeBSD yet.

Ah, ok. I did ye olde "grep -ri zstd" to see if I could test this. Didn't return any results and I thought I was daft.

In D16007#338923, @cem wrote:

Edit: https://reviews.freebsd.org/D11124 — I guess it's not in OpenZFS nor FreeBSD yet.

Ah, ok. I did ye olde "grep -ri zstd" to see if I could test this. Didn't return any results and I thought I was daft.

Ya, mea culpa. I think you are good from the ZFS side for now; it'll be up to Allan to use the option/macro.

This revision is now accepted and ready to land.Jun 25 2018, 7:02 PM

I'll update the zstd-zfs patch to deal with this once it lands, it shouldn't be an issue.

Add riscv and mips configurations to keep ZSTDIO building for
the GENERIC target and MALTA targets (std.MALTA).

This revision now requires review to proceed.Jun 29 2018, 3:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 5 2018, 5:07 PM
This revision was automatically updated to reflect the committed changes.