Consistently use explicit_bzero() for _Final methods.
ClosedPublic
Actions

Authored by delphij on Jul 18 2018, 7:02 AM.

Details

Reviewers

jmg
cperciva
pfg
allanjude

Group Reviewers

manpages

Commits

rS336539: libmd: Always erase context in _Final method, and when doing

Summary

Consistently use explicit_bzero() for _Final methods.

Test Plan

Run test cases of the libmd rountines.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij created this revision.Jul 18 2018, 7:02 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 18 2018, 7:02 AM

Harbormaster completed remote builds in B18114: Diff 45446.Jul 18 2018, 7:02 AM

Update manual pages and other hash rountines.

Herald added a reviewer: manpages. · View Herald TranscriptJul 18 2018, 7:34 AM

Harbormaster completed remote builds in B18115: Diff 45448.Jul 18 2018, 7:34 AM

delphij edited the test plan for this revision. (Show Details)Jul 18 2018, 7:34 AM

delphij added a reviewer: allanjude.

pfg accepted this revision.Jul 18 2018, 3:16 PM

This revision is now accepted and ready to land.Jul 18 2018, 3:16 PM

allanjude accepted this revision.Jul 18 2018, 4:26 PM

looks good. Thanks.

Closed by commit rS336539: libmd: Always erase context in _Final method, and when doing (authored by delphij). · Explain WhyJul 20 2018, 7:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libmd/

2 lines

2 lines

6 lines

6 lines

6 lines

6 lines

6 lines

6 lines

6 lines

6 lines

4 lines

sys/

crypto/

sha2/

sha256c.c

2 lines

sha512c.c

8 lines

skein/

skein.c

3 lines

Diff 45584

View Options

head/lib/libmd/md4c.c

View Options

head/lib/libmd/md5c.c

View Options

head/lib/libmd/mdX.3

View Options

head/lib/libmd/ripemd.3

View Options

head/lib/libmd/rmd160c.c

View Options

head/lib/libmd/sha.3

View Options

head/lib/libmd/sha0c.c

View Options

head/lib/libmd/sha1c.c

View Options

head/lib/libmd/sha256.3

View Options

head/lib/libmd/sha512.3

View Options

head/lib/libmd/skein.3

View Options

head/sys/crypto/sha2/sha256c.c

View Options

head/sys/crypto/sha2/sha512c.c

View Options

head/sys/crypto/skein/skein.c

Consistently use explicit_bzero() for _Final methods.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45584

head/lib/libmd/md4c.c

head/lib/libmd/md5c.c

head/lib/libmd/mdX.3

head/lib/libmd/ripemd.3

head/lib/libmd/rmd160c.c

head/lib/libmd/sha.3

head/lib/libmd/sha0c.c

head/lib/libmd/sha1c.c

head/lib/libmd/sha256.3

head/lib/libmd/sha512.3

head/lib/libmd/skein.3

head/sys/crypto/sha2/sha256c.c

head/sys/crypto/sha2/sha512c.c

head/sys/crypto/skein/skein.c

Consistently use explicit_bzero() for _Final methods.
ClosedPublic
Actions

Revision Contents
Changeset List