Page MenuHomeFreeBSD
Differential D21612

acpi_cros_tbmc: New driver for Chromebook Tablet Mode Switch
Needs ReviewPublic
Actions

Authored by val_packett.cool on Sep 12 2019, 12:21 AM.
Tags
None
Referenced Files
F171591796: D21612.diff
Fri, Sep 11, 11:38 PM
F171571701: D21612.diff
Fri, Sep 11, 8:12 PM
Unknown Object (File)
Fri, Sep 11, 5:03 AM
Unknown Object (File)
Tue, Sep 8, 1:37 AM
Unknown Object (File)
Sat, Sep 5, 12:08 AM
Unknown Object (File)
Fri, Sep 4, 10:31 PM
Unknown Object (File)
Fri, Sep 4, 9:58 PM
Unknown Object (File)
Tue, Sep 1, 9:22 PM
View All Files
Subscribers
darkfiberiru_gmail.com
dmitryluhtionov_gmail.com
imp

Details

Reviewers
None
Group Reviewers
Contributor Reviews (src)
desktop
Summary

This ACPI device exposed by the Chrome EC reports when a laptop-tablet convertible Chromebook (e.g., Google Pixelbook) is switched to tablet mode. Like on Linux, the reporting is via evdev:

-event3   SWITCH_TOGGLE     +3.27s      switch tablet-mode state 1
 event3   SWITCH_TOGGLE     +8.63s      switch tablet-mode state 0

though it would be possible to add other kinds notifications I guess.

Sponsored by: https://www.patreon.com/valpackett

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

val_packett.cool created this revision.Sep 12 2019, 12:21 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 12 2019, 12:21 AM
darkfiberiru_gmail.com added a subscriber: darkfiberiru_gmail.com.Sep 12 2019, 6:40 PM

@imp Is it possible to get this and acpi_ibm autoloaded with devmatch? Not sure if it would work with current structure or need additional code paths inside devmatch itself.

val_packett.cool mentioned this in D21746: acpi_cros_kblt: New driver for Chromebook keyboard backlight control.Sep 22 2019, 11:06 AM
val_packett.cool updated this revision to Diff 116451.Feb 4 2023, 6:22 AM
val_packett.cool retitled this revision from acpi_cros_tbmc: New driver for Chromebook "Tablet Motion Controls" (tablet mode switch) to acpi_cros_tbmc: New driver for Chromebook Tablet Mode Switch.
val_packett.cool added a reviewer: desktop.
val_packett.cool changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

Added a manpage and a files entry for building into the kernel

val_packett.cool updated this revision to Diff 116455.Feb 4 2023, 6:43 AM

oops, also don't add $FreeBSD$ to new files

val_packett.cool updated this revision to Diff 116456.Feb 4 2023, 6:49 AM
val_packett.cool updated this revision to Diff 116457.Feb 4 2023, 7:04 AM

update via git-arc

Harbormaster completed remote builds in B49519: Diff 116457.Feb 4 2023, 7:04 AM
val_packett.cool edited the summary of this revision. (Show Details)Feb 4 2023, 7:06 AM
dmitryluhtionov_gmail.com added a subscriber: dmitryluhtionov_gmail.com.Mar 2 2023, 11:36 AM

Сan this link help?
https://patchwork.kernel.org/project/linux-acpi/patch/1472628817-3145-1-git-send-email-wnhuang@google.com/

val_packett.cool added a comment.Mar 2 2023, 4:34 PM
In D21612#884481, @dmitryluhtionov_gmail.com wrote:

Сan this link help?
https://patchwork.kernel.org/project/linux-acpi/patch/1472628817-3145-1-git-send-email-wnhuang@google.com/

No help is needed? :) That's the Linux patch adding support for the generic standard PNP0C60 device. And this here is the FreeBSD patch adding support for the Google specific GOOG0006 device.

dmitryluhtionov_gmail.com added a comment.Mar 6 2023, 12:13 PM

Can you integrate Google specific GOOG0006 device into acpi_button driver ?

Revision Contents
Changeset List

PathSize
share/
man/
man4/
2 lines
69 lines
sys/
conf/
1 line
dev/
acpi_support/
178 lines
modules/
acpi/
2 lines
acpi_cros_tbmc/
7 lines

Diff 116451

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/acpi_cros_tbmc.4

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/dev/acpi_support/acpi_cros_tbmc.c

Loading...
View Options

sys/modules/acpi/Makefile

Loading...
View Options

sys/modules/acpi/acpi_cros_tbmc/Makefile

Loading...