Okay, thanks for opening a review. Please, provide a full context for the patch, i.e. -U999999.

In D58240#1335929, @cperciva wrote:

The commit message refers to critical sections, but in fact counter_{enter,exit} are no-ops everywhere except powerpc, and somehow I doubt ENA will ever run on powerpcs. So the win here isn't about critical sections; it's just about reducing the number of atomic operations.

Can you measure an improvement in benchmarks? It's clearly a good change to make; I'm just wondering if it's big enough to show up.

The struct in_endpoints can also be anonymized easily, but that would highly likely affect something outside of FreeBSD. Another level of #define to be removed. Let me know what you think about this and I will dig deeper into this if we all agree.

Note: union in_dependaddr can be anonymized after small cleanup of lbgroup code and siftr(4). This removes another level of of defines for both IPv6 and IPv4. This may need universe/exp-run, though.

In D58256#1336173, @ali_mashtizadeh.com wrote:

Maybe I'm missing something but it doesn't look like this feature is completely implemented.

Validate uap->data to be the size of the structure.
Edit man page.