• Reword a sentence and recommand lstat(2) instead of stat(2)

Address Ed's comment: Add an UPDATING for hw.snd.maxunit being gone after this
patch. Will fill the date and commit hash once committed.

Apply recommended wording

In D44912#1024008, @emaste wrote:

Is hw.snd.maxunit documented anywhere today? I suspect we should have an entry in UPDATING at least reporting that it's removed.

Is hw.snd.maxunit documented anywhere today? I suspect we should have an entry in UPDATING at least reporting that it's removed.

In D43966#1023788, @bz wrote:

@cc Adding LOCK asserts is a very good idea; not all the functions need them if I remember correctly. Should I really add it to this "fix" or should I do a separate full pass on the linux_80211_macops.c file?

In D44911#1023975, @0mp wrote:

Use a glob

BBR isn't going to be removed, so abandon that revision.

Instead, it should be only resolved locally, causing undefined symbol error if attempt is made to reference it from kld without the module symbol (section ?).

Fix a stupid typo.

See https://reviews.freebsd.org/D44905

Use a glob

• Fix "|"
• Add "restrict"
• Fix indentation

• leave #ifndef CAPSICUM in the source requested by @des (for the benefit of downstreams)
• remove src.opts.mk logic

• Reference clock_gettime from SEE ALSO

• Simplify freeing of old_format.

• Move the ts global variable to main()
  • We pass long nsec to printisodate() because printisodate() does not require the seconds part of timespec. However, setthetime does need both seconds and nanoseconds of timespec, so it makes more sense to pass the whole stuct there.

Update usage() and sort variable declarations in strftime_ns().

Removed unused LIB_DEPENDS:

Warning: you might not need LIB_DEPENDS on libasound.so
Warning: you might not need LIB_DEPENDS on libcurl.so
Warning: you might not need LIB_DEPENDS on libopenjp2.so
Warning: you might not need LIB_DEPENDS on libpng.so
Warning: you might not need LIB_DEPENDS on libturbojpeg.so

And pet portclippy.

Address feedback.

I'll upload an updated patch shortly.

In D44868#1022920, @emaste wrote:

Do we need to add support to e.g. ELF Tool Chain readelf and nm to decode these values?

A flag. https://github.com/ARM-software/abi-aa/blob/main/aaelf64/aaelf64.rst#st_other-values lists it under Processor specific st_other flags.