Page MenuHomeFreeBSD

lffpires_ruabrasil.org (Luis Pires)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2018, 9:05 PM (35 w, 3 d)

Recent Activity

Jun 7 2018

lffpires_ruabrasil.org updated the summary of D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Jun 7 2018, 9:09 PM · PowerPC
lffpires_ruabrasil.org updated the summary of D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Jun 7 2018, 9:01 PM · PowerPC
lffpires_ruabrasil.org updated the diff for D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
  • Improved size checking
Jun 7 2018, 8:44 PM · PowerPC

Jun 6 2018

lffpires_ruabrasil.org updated the diff for D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.

Changed to reflect the correct behavior of OF_getencprop().
A patch to fix ofw_fdt_getprop() was submitted as D15680.

Jun 6 2018, 9:04 PM · PowerPC
lffpires_ruabrasil.org updated the summary of D15680: Have ofw_fdt_getprop() return the actual size of the value on success.
Jun 6 2018, 9:00 PM
lffpires_ruabrasil.org created D15680: Have ofw_fdt_getprop() return the actual size of the value on success.
Jun 6 2018, 8:57 PM
lffpires_ruabrasil.org added inline comments to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Jun 6 2018, 7:26 PM · PowerPC
lffpires_ruabrasil.org updated the diff for D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
  • Removed extra printf param
Jun 6 2018, 5:10 PM · PowerPC
lffpires_ruabrasil.org updated the diff for D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
  • Improved linux,initrd-{start,end} length checking
Jun 6 2018, 4:48 PM · PowerPC
lffpires_ruabrasil.org added inline comments to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Jun 6 2018, 2:34 PM · PowerPC

Jun 5 2018

lffpires_ruabrasil.org updated the summary of D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Jun 5 2018, 6:43 PM · PowerPC
lffpires_ruabrasil.org added a comment to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.

After further investigation, linux,initrd-start/end are always 32-bit values

That's odd, because they're 64-bit values in the device tree:

Node 0xe38: chosen

linux,initrd-end:
  00 00 00 00 00 00 00 00
linux,initrd-start:
  00 00 00 00 00 00 00 00
Jun 5 2018, 6:42 PM · PowerPC
lffpires_ruabrasil.org updated the diff for D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.

Rework after comments

Jun 5 2018, 6:39 PM · PowerPC
lffpires_ruabrasil.org updated the diff for D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.

Removed dummy comment

Jun 5 2018, 2:02 PM · PowerPC
lffpires_ruabrasil.org updated the diff for D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.

After further investigation, linux,initrd-start/end are always 32-bit values

Jun 5 2018, 2:00 PM · PowerPC
lffpires_ruabrasil.org created D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Jun 5 2018, 12:35 PM · PowerPC

Jun 4 2018

lffpires_ruabrasil.org added inline comments to D15118: memcpy optimization for powerpc64.
Jun 4 2018, 1:58 PM · PowerPC

May 28 2018

lffpires_ruabrasil.org added inline comments to D15512: Included VSX registers in powerpc core dumps.
May 28 2018, 1:05 PM · PowerPC

May 24 2018

lffpires_ruabrasil.org updated the diff for D15458: Added ptrace support for reading/writing powerpc VSX registers.
  • Added PT_GETVSRREGS/PT_SETVSRREGS to ptrace man pages
May 24 2018, 7:16 PM · PowerPC

May 21 2018

lffpires_ruabrasil.org added a project to D15512: Included VSX registers in powerpc core dumps: PowerPC.
May 21 2018, 7:25 PM · PowerPC
lffpires_ruabrasil.org updated subscribers of D15458: Added ptrace support for reading/writing powerpc VSX registers.
May 21 2018, 6:24 PM · PowerPC
lffpires_ruabrasil.org added reviewers for D15512: Included VSX registers in powerpc core dumps: jhibbits, nwhitehorn.
May 21 2018, 6:23 PM · PowerPC
lffpires_ruabrasil.org created D15512: Included VSX registers in powerpc core dumps.
May 21 2018, 6:20 PM · PowerPC

May 16 2018

lffpires_ruabrasil.org updated the summary of D15458: Added ptrace support for reading/writing powerpc VSX registers.
May 16 2018, 8:12 PM · PowerPC
lffpires_ruabrasil.org created D15458: Added ptrace support for reading/writing powerpc VSX registers.
May 16 2018, 8:05 PM · PowerPC

May 9 2018

lffpires_ruabrasil.org updated the diff for D15118: memcpy optimization for powerpc64.

Fixing diff in revision

  • memcpy optimization for powerpc64
  • moved vsx detection to C code (#3)
  • added license
  • set bcopy_has_vsx to 0 during vsx test and use elf_aux_info()
May 9 2018, 1:16 PM · PowerPC
lffpires_ruabrasil.org abandoned D15208: update __stack_chk_guard safely.
May 9 2018, 1:03 PM

May 7 2018

lffpires_ruabrasil.org added a comment to D15283: Created static pic libc with no SSP to be used by rtld.

2 follow up revisions created:
D15340 (Removed -fstack-protector-all restriction from libc)
D15341 (Updated rtld to use libc_nossp_pic.a)

May 7 2018, 5:14 PM
lffpires_ruabrasil.org updated the summary of D15340: Removed -fstack-protector-all restriction from libc.
May 7 2018, 5:13 PM
lffpires_ruabrasil.org updated the summary of D15341: Updated rtld to use libc_nossp_pic.a.
May 7 2018, 5:12 PM
lffpires_ruabrasil.org updated the summary of D15340: Removed -fstack-protector-all restriction from libc.
May 7 2018, 5:12 PM
lffpires_ruabrasil.org created D15341: Updated rtld to use libc_nossp_pic.a.
May 7 2018, 5:10 PM
lffpires_ruabrasil.org created D15340: Removed -fstack-protector-all restriction from libc.
May 7 2018, 5:07 PM
lffpires_ruabrasil.org updated the summary of D15283: Created static pic libc with no SSP to be used by rtld.
May 7 2018, 5:00 PM
lffpires_ruabrasil.org added a comment to D15283: Created static pic libc with no SSP to be used by rtld.

Made changes according to review comments.

May 7 2018, 5:00 PM
lffpires_ruabrasil.org updated the diff for D15283: Created static pic libc with no SSP to be used by rtld.
  • Separated libc restriction- and rtld-related changes
  • Removed unnecessary MK_TOOLCHAIN check
May 7 2018, 4:53 PM

May 3 2018

lffpires_ruabrasil.org added a comment to D15208: update __stack_chk_guard safely.
In D15208#320453, @kib wrote:

I think this is more involved than just avoiding memcpy(). If you look at the libexec/rtld-elf/Makefile near the start, you would see MK_SSP=no. In other words, we know that rtld must be compiled without stack protector, but you effectively point out that libc_pic.a is compiled with it, and this causes more troubles.

I suggest to consider changing the build for libc_pic.a to also avoid -fstack-protector instead of fixing the single place.

May 3 2018, 9:18 PM
lffpires_ruabrasil.org created D15283: Created static pic libc with no SSP to be used by rtld.
May 3 2018, 9:14 PM

Apr 26 2018

lffpires_ruabrasil.org updated the summary of D15208: update __stack_chk_guard safely.
Apr 26 2018, 12:26 PM
lffpires_ruabrasil.org created D15208: update __stack_chk_guard safely.
Apr 26 2018, 12:15 PM

Apr 25 2018

lffpires_ruabrasil.org updated subscribers of D15173: udpate stack guard bytes inside __guard_setup().
Apr 25 2018, 6:57 PM
lffpires_ruabrasil.org updated subscribers of D15118: memcpy optimization for powerpc64.
Apr 25 2018, 6:56 PM · PowerPC

Apr 24 2018

lffpires_ruabrasil.org added a comment to D15118: memcpy optimization for powerpc64.

The fix for the stack protection issue was merged to main (D15173), so now this diff is ready to be considered for merging as well.

Apr 24 2018, 6:57 PM · PowerPC
lffpires_ruabrasil.org added a comment to D15173: udpate stack guard bytes inside __guard_setup().

@kib, I added them just because this showed up while working on an optimization for powerpc64, and at the time I didn't know who I should add as reviewer. Please feel free to commit this.

Apr 24 2018, 1:07 PM
lffpires_ruabrasil.org updated the diff for D15173: udpate stack guard bytes inside __guard_setup().
  • addressed review comments
Apr 24 2018, 12:42 PM

Apr 23 2018

lffpires_ruabrasil.org added inline comments to D15173: udpate stack guard bytes inside __guard_setup().
Apr 23 2018, 5:59 PM
lffpires_ruabrasil.org added a reviewer for D15173: udpate stack guard bytes inside __guard_setup(): kib.
Apr 23 2018, 5:58 PM
lffpires_ruabrasil.org added reviewers for D15173: udpate stack guard bytes inside __guard_setup(): nwhitehorn, jhibbits.
Apr 23 2018, 5:51 PM
lffpires_ruabrasil.org retitled D15173: udpate stack guard bytes inside __guard_setup() from udpate stack guard bytes inside __guard_setup This is necessary to make sure that functions that can have stack protection are not used to update the stack guard. In that case, the stack guard check would fail when it shouldn't. to udpate stack guard bytes inside __guard_setup().
Apr 23 2018, 5:50 PM
lffpires_ruabrasil.org created D15173: udpate stack guard bytes inside __guard_setup().
Apr 23 2018, 5:41 PM
lffpires_ruabrasil.org added inline comments to D15118: memcpy optimization for powerpc64.
Apr 23 2018, 5:27 PM · PowerPC
lffpires_ruabrasil.org updated the diff for D15118: memcpy optimization for powerpc64.

Use elf_aux_info() for VSX check and set bcopy_has_vsx during the check to avoid infinite loop
For this to work, I had to make changes to the stack guard setup code - I'll post those in a separate review.

Apr 23 2018, 5:23 PM · PowerPC

Apr 18 2018

lffpires_ruabrasil.org added inline comments to D15118: memcpy optimization for powerpc64.
Apr 18 2018, 7:37 PM · PowerPC
lffpires_ruabrasil.org updated the diff for D15118: memcpy optimization for powerpc64.

Moved VSX detection to C code - now it should be simpler to migrate to ifunc's in the future.
Changed to /* */ - style comments.
Removed unnecessary references to %cr0.

Apr 18 2018, 6:42 PM · PowerPC
lffpires_ruabrasil.org added a project to D15118: memcpy optimization for powerpc64: PowerPC.
Apr 18 2018, 3:37 PM · PowerPC

Apr 17 2018

lffpires_ruabrasil.org updated the summary of D15118: memcpy optimization for powerpc64.
Apr 17 2018, 6:50 PM · PowerPC
lffpires_ruabrasil.org added reviewers for D15118: memcpy optimization for powerpc64: jhibbits, nwhitehorn, breno.leitao_gmail.com.
Apr 17 2018, 6:47 PM · PowerPC
lffpires_ruabrasil.org updated the summary of D15118: memcpy optimization for powerpc64.
Apr 17 2018, 6:44 PM · PowerPC
lffpires_ruabrasil.org created D15118: memcpy optimization for powerpc64.
Apr 17 2018, 6:29 PM · PowerPC