In D55859#1278506, @glebius wrote:

Thanks a lot for working on that! I miss the feature a lot.

Sorry if a dumb question. Trying to understand the Makefile logic. The statement

${PACKAGE}SCRIPTS+=     demo.setup \
                        demo.atfsh_like_setup

does it apply to all tests in the Makefile or there is some magic that makes the first word before the dot to limit application only to a test that is named as this word? Where does this logic live?

fix

Causes a panic. Abandoning.

I think we should probably have tests check we do the correct things when we get a jumbogram. If these tests aren't run they don't really help with that.

LGTM. Feel free to commit.

Hi Adrian,

Isaac, let me know if you want to take over maintainership of this port for the long run. But if not, I'd be interested in keeping it going on the FreeBSD ports side.

In D55904#1279059, @glebius wrote:

In D55904#1279057, @imp wrote:

Do you need to validate the enum value is know?

Do you mean if somebody passes a numeric instead of one of enum values? I think our compiler flags will forbid that.

This time for sure!

Further error message refinement.

I'd suggest to use more specific commit line, e.g. ndp: handle a case when two timers coalesce for the same ifa. Or something else that you can come up with. Just more specific than "make things better" :)

Continue the WIP.
Handle NMIs and #MC.
Misc bug fixes.

Add sx(9) and rmlock(9) support.

Fix a minor issue on PATH_MASK.

Reuse ndq and cancel out previous pending NA for same ifa.
@glebius done.

i wonder: why is this in base, when pkg repository can only be built when pkg(8) is installed?

In D55904#1279057, @imp wrote:

Do you need to validate the enum value is know?

This is the commit message.

Do you need to validate the enum value is know?

I'll see if rmlock(9) and sx(9) can be added and update.

This is really clever. What about other lock types (rm / rms, sx, etc)?

Don't count for grand for delayed solicited NAs.

Valid complaint, but not sure what the error message should be for the third case.