In D55931#1279683, @jhb wrote:

Speaking of this btw, it might be nice to fix other architectures to also pull the pcb out of the kstack in general. Certainly for CHERI we prefer that arrangement.

In D55831#1279681, @jhb wrote:

FYI, kgdb will have to know about the change in layout to trapframe I think, so bump __FreeBSD_version when you land this just to be on the safe side please?

Actually, to support SEQ_SKIP (which is in the docs but we don't currently implement), I do indeed need to keep the sbuf_clear/finish in the loop. Will upload a new version in a bit.

Looks good to me.

Any chance we can make zstd a loadable module?

Two failures:

• Cross-build Kernel / aarch64 macos-latest (clang-18) Failed in 19 minutes and 24 seconds
• Cross-build Kernel / amd64 macos-latest (clang-18) Failed in 5 minutes and 15 seconds

Issue created: https://codeberg.org/tobik/portfmt/issues/34

Updating D55907: clk/broadcom: Add CPRMAN clkdev backend and peripheral clock node

It looks like the cross build is currently broken for other reasons

Humm, I guess I need the loop to just do show/next. I do think on a "short read" you need to return success, but yeah, the simple_read_from_buffer should perhaps be outside of the loop.

I think rather than trying to overload -B, it would be better to just use a different getopt() letter for this mode. I would suggest using -R for reading from a BAR but keep 'D' as an alias for backwards compatibility, and using -W for writing into a BAR.

Updating D55909: clk/broadcom: Add stub clock node for unimplemented clock sources

Updating D55908: clk/broadcom: Add PLL and PLL channel clock nodes

In D55857#1278584, @cperciva wrote:

In D55857#1278564, @kib wrote:

Did you tried enabling DMAR/AMD IOMMU and interrupt remapping on this machine?

This (virtual) machine doesn't have a proper IOMMU. See http://david.woodhou.se/15-bit-msi.pdf for context.

@kib What if we reclaimed some of the spare fields in ifi2creq to a uint16_t magic field. User sets i2creq.magic=PAGE_BANK_REQ and driver sets magic=PAGE_BANK_ACK ? That prevents the confusion you're concerned about.

In D55931#1279683, @jhb wrote:

Speaking of this btw, it might be nice to fix other architectures to also pull the pcb out of the kstack in general. Certainly for CHERI we prefer that arrangement.

Speaking of this btw, it might be nice to fix other architectures to also pull the pcb out of the kstack in general. Certainly for CHERI we prefer that arrangement.

FYI, kgdb will have to know about the change in layout to trapframe I think, so bump __FreeBSD_version when you land this just to be on the safe side please?

No need to touch proxy_ndp tests.
Remove it.

Rebase to D55905.

sys/netinet6/proxy_ndp:pndp_add_gu_success  ->  passed  [2.529s]
sys/netinet6/proxy_ndp:pndp_del_gu_success  ->  passed  [4.840s]
sys/netinet6/proxy_ndp:pndp_ifdestroy_success  ->  passed  [2.899s]
sys/netinet6/proxy_ndp:pndp_neighbor_advert  ->  passed  [5.192s]

@kevans I set you as a reviewer since you seems to have pointed @imp at something he'd started that will help that a lot... ;)

I submitted a PoC following our discussion, see D55936.

Update WITHOUT_LLVM_BINUTILS_BOOTSTRAP description.

I sent (cc you) an email to Harlan Stenn, the primary developer at nwtime.org. (nwtime.org is replacing the ntp.org). Let's see what he says.

Why put the message here, now?

Abandoning since D55901 was abandoned as well.

Address Mark's comment: if umidi_attach() fails, set sc->sc_midi_chan.valid to
0, and check that in umidi_detach().

In D54172#1277853, @pouria wrote:

Do you think removing nvlist/non-netlink support will help this revision get reviewed faster?
since it will reduce the code size.

Merged with parent.

Rebase to main, apply and close D55186.

Hm, at first I was confused because TOOLS_PREFIX seems to be tested in the first .if statement, but that is only for the tblgen tools. But LGTM.

We are probably fine here.

From what I can see, now, we initialize the mutex only if sc_midi_chan.valid is true, but we will destroy it unconditionally, so we might destroy an uninitialized mutex.

This change is still not merged in.