libusb: hotplug, use events instead of a timer when possible
Needs ReviewPublic
Actions

Authored by bapt on Fri, Jan 3, 1:34 PM.

Details

Reviewers

emaste
kevans

Group Reviewers

USB

Summary

Try to fetch events from nlsysevent or devd to determine when
to scan the usb bus for devices addition or removal.
if none are available fallback on the regular timer based (4s)
scanner

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61499
Build 58383: arc lint + arc unit

Event Timeline

bapt created this revision.Fri, Jan 3, 1:34 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 3, 1:34 PM

bapt requested review of this revision.Fri, Jan 3, 1:34 PM

Harbormaster completed remote builds in B61477: Diff 148720.Fri, Jan 3, 1:34 PM

bapt added a reviewer: emaste.Fri, Jan 3, 1:35 PM

push the right patch

Harbormaster completed remote builds in B61478: Diff 148721.Fri, Jan 3, 1:36 PM

unexpected stuff added

Harbormaster completed remote builds in B61479: Diff 148722.Fri, Jan 3, 1:38 PM

bapt added a reviewer: kevans.Fri, Jan 3, 2:34 PM

rebase

Harbormaster completed remote builds in B61499: Diff 148763.Sat, Jan 4, 10:23 AM

bapt added a reviewer: USB.Sat, Jan 4, 4:41 PM

mohammad_fbsdphab_thelightbird.com added a subscriber: mohammad_fbsdphab_thelightbird.com.Sun, Jan 5, 4:25 PM

mohammad_fbsdphab_thelightbird.com added inline comments.Sun, Jan 5, 4:46 PM

lib/libusb/libusb10_hotplug.c
57	Hi @bapt, According to devd(8) '/var/run/devd.pipe' is deprecated in favor for '/var/run/devd.seqpacket.pipe', any reason for still using it here ?

Looks fine in principle

lib/libusb/libusb10_hotplug.c
176	This doesn't seem like it would work?
192	IMO "ignore any error" should just be a (void) cast for the return vaule, but I don't feel strongly about it.
192	Where is `timeout` coming from here? With this and the above, kinda seems like something went wrong with the patch.

emaste added inline comments.Mon, Jan 6, 4:14 PM

lib/libusb/libusb10_hotplug.c
192	Yeah not a huge issue but I agree `(void)poll(...)` is both a programmer-readable and machine-readable way to indicate that errors are intentionally ignored.