uefisign: rename to efisign
AcceptedPublic
Actions

Authored by kevans on Sun, Jul 12, 2:14 AM.

Details

Reviewers

imp
emaste
ziaee

Summary

uefisign seems to have come first, but the efi* naming has won out in
our UEFI tooling and consistency is good. This fixes it so that
"efi<tab>" gives a reasonable view of what efitools we have in base.

uefi* links are added for compatibility, at least for now. Maybe it's
a reasonable idea to add such links for all of the efi tools, but I'm
punting on that for a moment.

Relnotes: maybe

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74755
Build 71638: arc lint + arc unit

Event Timeline

kevans created this revision.Sun, Jul 12, 2:14 AM

Herald added subscribers: ziaee, jonathan. · View Herald TranscriptSun, Jul 12, 2:14 AM

kevans requested review of this revision.Sun, Jul 12, 2:14 AM

Harbormaster completed remote builds in B74736: Diff 181814.Sun, Jul 12, 2:14 AM

kevans added a child revision: D58186: efisign: add to the efi-tools package.Sun, Jul 12, 2:15 AM

See also D14031. I didn't like the idea of offering all tools with both efi* and uefi* names, but standardizing on efi* and leaving backwards compat links for tools that started as uefi* seems fine.

Name change is fine with me

This revision is now accepted and ready to land.Sun, Jul 12, 2:53 AM

I had similar patches in my tree for a while, but these aremore complete and better. Thanks!!!

\o/

I support this since we do not even have doc on uefisign yet, nor have built any tooling around it. This is a win for consistency and reduced operator mental load. We also need to update these files:

$ cd src; git grep uefisign
etc/mtree/BSD.usr.dist:            uefisign
share/man/man8/uefi.8:.Xr uefisign 8
targets/pseudo/userland/Makefile.depend:        usr.sbin/uefisign \

usr.sbin/efisign/Makefile

This is weird, we only use MLINKS in the tree since intro.1.

I kinda hate that, I want switch intro.1 to the same syntax everything else is using for grep purposes:

$ git grep MANLINKS
share/man/man1/Makefile:MANLINKS=       intro.1 introduction.1
share/mk/bsd.man.mk:# MANLINKS.  However it's actually called MLINKS, so for compatibility,
share/mk/bsd.man.mk:MANLINKS=   ${MLINKS}
share/mk/bsd.man.mk:_MANLINKS=
share/mk/bsd.man.mk:_MANLINKS+= ${MANDIR}${_osect}${MANSUBDIR}/${_oname} \
share/mk/bsd.man.mk:_MANLINKS+= ${CATDIR}${_osect}${MANSUBDIR}/${_oname} \
share/mk/bsd.man.mk:.for l t in ${_MANLINKS}

Whack the remaining moles, fix OptionalObsoleteFiles to also remove the example

This revision now requires review to proceed.Sun, Jul 12, 7:59 PM

Herald added a subscriber: ivy. · View Herald TranscriptSun, Jul 12, 7:59 PM

Harbormaster completed remote builds in B74755: Diff 181856.Sun, Jul 12, 7:59 PM

this might be a good time to move this to the FreeBSD-efi-tools package. it's probably a bug/oversight that it isn't already there.

In D58187#1338218, @ivy wrote:

this might be a good time to move this to the FreeBSD-efi-tools package. it's probably a bug/oversight that it isn't already there.

There's a follow-up in the stack that does this: https://reviews.freebsd.org/D58186

I was trying to decide if I wanted to apply it before the rename, but since we're leaving compatibility links in place I don't think I mind MFCing the rename as well.