Page MenuHomeFreeBSD

ithread(9): update functions to current day
ClosedPublic

Authored by mhorne on Dec 15 2021, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 17 2024, 6:54 PM
Unknown Object (File)
Nov 17 2024, 6:35 PM
Unknown Object (File)
Nov 17 2024, 4:27 PM
Unknown Object (File)
Oct 23 2024, 4:49 AM
Unknown Object (File)
Oct 23 2024, 4:49 AM
Unknown Object (File)
Oct 23 2024, 4:49 AM
Unknown Object (File)
Oct 23 2024, 4:49 AM
Unknown Object (File)
Oct 23 2024, 4:32 AM

Details

Summary

The public KPI is now intr_event_**,

  • Convert existing documented functions to their equivalents.
  • Fix up the function arguments
  • Fix up the possible error return values for each
  • Remove ithread_schedule() completely
  • Fix up MLINKS

Future changes will update the descriptive text for these functions, and
add documentation for some of the newer functions that are missing.

PR: 100803
Based on work by: trhodes, ygy

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47268
Build 44155: arc lint + arc unit

Event Timeline

share/man/man9/Makefile
1316–1319

I was thinking we'd keep ithread.9, but maybe it doesn't really make sense to do so.

I think it is fine to ditch ithread.9 and just have intr_event.9.

This revision is now accepted and ready to land.Dec 15 2021, 7:53 PM
pauamma_gundo.com added inline comments.
share/man/man9/intr_event.9
91

Is "entr" a typo for "intr"?

105
113

Since you're touching that area, "an interrupt thread" should be "the interrupt thread" here, if you're referring to the same one mentioned on the previous line.

Fix small nits, rename page to intr_event.9

This revision now requires review to proceed.Sep 6 2022, 8:46 PM
This revision is now accepted and ready to land.Sep 30 2022, 8:58 PM

A few nits, but this is way beyond me.

share/man/man9/intr_event.9
26

Reminder (if needed) to bump on commit.

204

While there, maybe change this to .Xr swi_add 9 to make it clearer it's not just an example and for easier comprehension of what the example does, not just how it does it? (I'm not part of the intended audience, so if you feel it's not needed, that's fine with me.)

share/man/man9/socket.9
174

Maybe .Xr intr_event 9?

mhorne added inline comments.
share/man/man9/intr_event.9
26

Yes, will do.

204

Sure, it will be done as part of D33476.

share/man/man9/socket.9
174

I wanted to retain the reference, but I did not find a way to word it that makes sense. "intr_event" is the new name of the KPI, but you wouldn't really refer to an object as an "intr_event" in the same way that you can with an "ithread".

This revision was automatically updated to reflect the committed changes.
mhorne marked 2 inline comments as done.