xenpv.c
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Mar 3 2021, 4:34 PM.

Details

Reviewers

royger
mhorne

Commits

rGa48f7ba444fd: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c

Summary

Minor changes are necessary to make this processor-independent, but
moving the file out of x86 and into common is the first step (so others
don't add /more/ x86-isms).

Adapted-to-HEAD-by: Elliott Mitchell <ehem+freebsd@m5p.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37542
Build 34431: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Mar 3 2021, 4:34 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 3 2021, 4:34 PM

ehem_freebsd_m5p.com requested review of this revision.Mar 3 2021, 4:34 PM

Harbormaster completed remote builds in B37542: Diff 85060.Mar 3 2021, 4:34 PM

ehem_freebsd_m5p.com added reviewers: royger, mhorne.Mar 3 2021, 6:02 PM

ehem_freebsd_m5p.com changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

I would consider placing it in sys/dev/xen/bus/xenpv.c

Yeah, I've got no idea what-so-ever why one might feel xenpv.c should be
in a "bus" directory. No similarity to any type of bus. No devices
attached at all. Certainly not a bus.

Like so many comments, that one is pretty obvious when suggested.

Harbormaster completed remote builds in B37579: Diff 85149.Mar 4 2021, 5:25 PM

In D29042#650907, @ehem_freebsd_m5p.com wrote:

Yeah, I've got no idea what-so-ever why one might feel xenpv.c should be
in a "bus" directory. No similarity to any type of bus. No devices
attached at all. Certainly not a bus.

I'm confused by the text above, do you agree it should be in a bus/ directory or not?

There are Xen devices (xen timer, xenstore) that attach to the xenpv bus.

In D29042#650912, @royger wrote:

I'm confused by the text above, do you agree it should be in a bus/ directory or not?

There are Xen devices (xen timer, xenstore) that attach to the xenpv bus.

My actual view should be reflected in the diff update. I went ahead and moved as requested. Felt like a 20/20 hindsight comment, it does look like a bus since it has devices attached and as such the idea is entirely reasonable.

ehem_freebsd_m5p.com retitled this revision from xen: move x86/xen/xenpv.c to dev/xen/xenpv.c to xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.Mar 4 2021, 9:48 PM

ehem_freebsd_m5p.com changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

ehem_freebsd_m5p.com mentioned this in D29351: xen: create VM_MEMATTR_XEN for Xen memory mappings.Mar 20 2021, 4:34 PM

royger accepted this revision.Mar 25 2021, 4:02 PM

This revision is now accepted and ready to land.Mar 25 2021, 4:02 PM

ehem_freebsd_m5p.com added a subscriber: julien_xen.org.Mar 30 2021, 6:42 PM

ehem_freebsd_m5p.com added a child revision: D29351: xen: create VM_MEMATTR_XEN for Xen memory mappings.May 13 2021, 10:51 PM

ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jun 30 2021, 1:28 AM

ehem_freebsd_m5p.com added a parent revision: D30228: x86/xen: remove PVHv1 code.Jul 6 2021, 2:10 AM

ehem_freebsd_m5p.com added a parent revision: D29873: etc/ttys: add the xen console.Jul 15 2021, 5:12 AM

Closed by commit rGa48f7ba444fd: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c (authored by julien_xen.org, committed by royger). · Explain WhyJul 28 2021, 3:28 PM

This revision was automatically updated to reflect the committed changes.

royger added a commit: rGa48f7ba444fd: xen: move x86/xen/xenpv.c to dev/xen/bus/xenpv.c.