Differential D44332

pca963x: add support for the PCA9633 4-bit Fm+ I2C-bus LED driver
Needs ReviewPublic
Actions

Authored by bz on Mar 12 2024, 9:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jun 20, 3:36 PM

	Unknown Object (File)
	Tue, Jun 4, 10:30 AM

	Unknown Object (File)
	May 14 2024, 5:52 PM

	Unknown Object (File)
	Apr 26 2024, 4:09 AM

	Unknown Object (File)
	Mar 15 2024, 7:19 PM

	Unknown Object (File)
	Mar 15 2024, 1:11 AM

Subscribers

Details

Reviewers

andrew
manu

Group Reviewers

Summary

In the absence of a full LED framework, allow the LEDs to be toggled
on/off using gpiobus.
We do not support any brightness control currently, blinking, group
settings, etc.
The feature we do support, given I missed to toggle it on first pass
and stared at the blank darkness, is low power mode, so that the
osciallator stays off if no LEDs are on.

This allows us to at least signal some status using the LEDs present
on SoCs even if we cannot easily morse or disco.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56567
Build 53455: arc lint + arc unit

Event Timeline

bz created this revision.Mar 12 2024, 9:41 PM

Herald added a reviewer: andrew. · View Herald TranscriptMar 12 2024, 9:41 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: loos, emaste, imp. · View Herald Transcript

bz requested review of this revision.Mar 12 2024, 9:41 PM

Harbormaster completed remote builds in B56567: Diff 135674.Mar 12 2024, 9:42 PM

Anyone any comments? Otherwise I'll put that in soon.

I don't understand enough to review in depth but looks OK. One nit I noticed in a comment.

sys/dev/iicbus/gpio/pca963x.c
31

Revision Contents
Changeset List

Path

Size

sys/

arm64/

conf/

1 line

conf/

1 line

dev/

iicbus/

gpio/

546 lines

Diff 135674

sys/arm64/conf/std.nxp

Loading...

sys/conf/files

Loading...

sys/dev/iicbus/gpio/pca963x.c

Loading...