We already discussed this issue internally, it must be fixed.
The technical reason of this error - though the document is in AsciiDoc format, the block delimited by --- is considered as YAML language block (assignment of 2 variables: title and sidenav), and --- must start at the 1st line of the file, otherwise it will be considered as AsciiDoc code with wrong syntax. That comment about original hash should be placed somewhere inside of the document.

Approved.

Approved.

Approved.

This looks good to me, but I will await a review from Johan before proceeding.

tags

add more files

tags

PBKAC

Hm, not sure I'd call AES deprecated or disallowed. But no objection to removing.

In D53178#1214927, @guest-svmhdvn wrote:

I think this commit is missing an addition to BSD.tests.dist because I get an error during make installworld. I've posted a quick github PR here, could you review and merge if it's correct? https://github.com/freebsd/freebsd-src/pull/1877

Do you have stats how many classes can be realistically present? maybe this would be way faster iterating an array?

I think this commit is missing an addition to BSD.tests.dist because I get an error during make installworld. I've posted a quick github PR here, could you review and merge if it's correct? https://github.com/freebsd/freebsd-src/pull/1877

I could only find PCI cards with this chipset (SafeXcel 140-PCI, SafeXcel 141-PCI, SafeXcel 171-PCI, and SafeXcel 241-PCI), nothing newer to plug into a modern AMD64 system. I haven't yet found any(which) SoC's may have the SafeXcel embedded, but I doubt they are 64-bit capable.

tags

Fix check if the provider is NULL

Fixed typos

before:

          Name  Status  Components
  gpt/efiboot0     N/A  N/A
msdosfs/EFISYS     N/A  N/A
  gpt/gptboot0     N/A  N/A
  gpt/efiboot1     N/A  N/A
  gpt/gptboot1     N/A  N/A

In D53100#1214836, @gallatin wrote:

In D53100#1214833, @akiyano_amazon.com wrote:

I built and installed the latest kernel with this patchset in AWS and ran a network sanity check with iperf and all looks good.

turned on net.inet.tcp.input_verify_hash with sysctl net.inet.tcp.input_verify_hash=1

ran traffic

lookede at

sysctl net.inet.tcp.input_nohash
sysctl net.inet.tcp.input_badhash

and both were 0

no prints to dmesg

commit lgtm.

Thank you so much for quick and complete testing. Much appreciated!

Looks plausible to me. I don't know enough about the bits to confirm that everything now goes in the right places but assuming you've tested that should be fine.