Since our syslogd's default configuration started including additional configurations installed with non-base packages, it is no more acceptable for it to use err*() functions based on syntax errors in such configuration files. Instead, it should issue a warning, skip bad line and continue with execution. Please do not add new err*() to the syslogd but warn*() with graceful recovery.

In D54519#1257714, @michaelo wrote:

Let me rephrase: The version banner should be complete in terms of information regards of the args passed to device_printf. At runtime the passed dev does not know (ahead of time) that the string mrsas/mfi is contained in the version banner. How can this assumption be made at compile time?

Address jilles and ziaee comments.

• Disable interrupts on MSR_OP_LOCAL and non-atomic MSR manipulation.
• Trim and update comments.

There're three tasks in this change,

In D52465#1257867, @timo.voelker_fh-muenster.de wrote:

In D52465#1257581, @zarychtam_plan-b.pwste.edu.pl wrote:

Please bear in mind that the above change, as well as "epair: add support for checksum offloading" (https://reviews.freebsd.org/D51639) are incompatible with netmap(4). If the epair(4) interface is used in netmap mode, communication is broken. It never happens on physical interfaces with netmap support, like for example ix(4) where these NIC capabilities don't need to be disabled.

Thanks for the note. I've never used netmap.

If netmap support is added to epair, I guess it's possible to disable these features when epair switches to netmap mode. I don't know whether epair notices this switch without netmap support (i.e., when used with emulation). I guess, manually disabling theses features is required (as netmap(4) recommends).

Drop redundant terms

kind reminder
@glebius

kind reminder.
@tuexen @rscheff

At first look only:

• • the '#ifndef MT7531' is clearly incompatible with GENERIC kernel.
• the defined FDT bindings between the NIC and the switch are not followed. Instead, a "brutal" hack (fdt_find_ethernet_prop_switch) is used.
• the eqos driver changes is improper. All of these are should be in attached the phy driver.

@bz I've fixed the c&p error to address your comments. Could you please take another look?

In D52465#1257581, @zarychtam_plan-b.pwste.edu.pl wrote:

Please bear in mind that the above change, as well as "epair: add support for checksum offloading" (https://reviews.freebsd.org/D51639) are incompatible with netmap(4). If the epair(4) interface is used in netmap mode, communication is broken. It never happens on physical interfaces with netmap support, like for example ix(4) where these NIC capabilities don't need to be disabled.

update diff, remove unnecessary code

Apple do not provide meaningful change history in their xnu drops on GitHub, which is extremely inconvenient.
OT: I am in touch separately with core-secretary@ to open a dialogue about regaining full commit access after a 7.5 year hiatus for health & bereavement reasons.

• Rebase

• Implement a strsuftoll(3)-compatible function, as the value of NANO_SLICE_FAT_SIZE should be compatible with makefs(8) -s.