And while here, also mandoc -Tlint a bit.

• Fix the two QCA entries which depend on two packages
• Update the comments on Intel iwlwifi removing some initial logic in favor of a script (it is currently two but I'll try to clean it up and add it either to src or ports to generate both the fwget case pattern and the ports flavor->firmware files list generation)

I don't see any more path where the pointer to the new struct thread won't be initialized before the new thread is started, so I think this completely fixes the initial problem. Moreover, there most probably won't be any noticeable performance impact, since kproc_create() in the end calls fork1() with RFSTOPPED, so the only difference is now that the new process will be released only very slightly later.

In D44918#1024641, @manu wrote:

Looks better now, thanks a lot.

This update fixes smaller issues. The proposal to restructure the reset code by creating a new base class is left for later.

• Remove unused variable olderrno
• Use size_t for prefixlen

@jamie this not longer builds against CURRENT, if possible can you massage it a little, and then commit it so we don't get any more rot? I fixed symbol.map changes in https://git.sr.ht/~dch/src/commit/9051eedd52fc but that's not sufficient.

Thank you for the review!

In D44911#1023994, @des wrote:

In D44911#1023975, @0mp wrote:

Use a glob

Kleene star, not glob, these are regular expressions.

I have a temp fix for this directly in ice and will work with erj@ to have the driver support the vlan ifconfig flags correctly

Looks better now, thanks a lot.
Do you have a review for the ports change ?

In D44774#1024470, @glebius wrote:

The switching code should just use a local variable to convert between prio and adnskew.

We can't convert between them. They're not different representations of the same concept, they just represent different things.

With minor modifications and updated comms/iwmbtfw it works with AX211.

update diff url

In D44827#1024357, @cc wrote:

In D44827#1023217, @adrian wrote:

In D44827#1023209, @bz wrote:

In D44827#1023208, @adrian wrote:

eg ath(4) would do something like:

How do you want to implement ath_settkipmic() "nicely" without exposing the field?

oops my bad. it'll be a flag for hardware encryption support! I fixed the code snippet.

I don't get it. Without exposing the field ic_cryptocaps? And where is the "fixed the code snippet"?

In D44827#1024561, @bz wrote:

Are you going to change the few drivers which need change to get rid of the public exposure as well? Otherwise this is a dead code before added.

address comments from cc@

update w/ diff url

So I'm not saying we need it now, but we likely need to know if we can... get some sleep

SOCKET_HHOOK instead of TCP_HHOOK

In D44918#1024544, @imp wrote:

I don't suppose that yhese could be generated automatically? It's a huge table to maintain by hand...

Is is likely mis-sorted in the stack as this should go after D44922?

Are you going to change the few drivers which need change to get rid of the public exposure as well? Otherwise this is a dead code before added.

I haven't reviewed the actual function changes yet; just scrolled through

I don't suppose that yhese could be generated automatically? It's a huge table to maintain by hand...

Any reason to not always set cn_unmute = 0 unconditionally?

Update to fine(r) grained flavored packages.