Use the same semantic for cklen as in the UDP case.

If M_RX gets unset, the device file was closed, so no read will occur anymore and draining or keeping data is useless. I made a successful test with this extra lock/unlock.

LGTM. For me I would extract a new variable like ${BRANCH_SAFE} (or a better name. I can't think of a good one right now) to run and hold the regexp processed result, for easier maintaining in the future.

I'm also going to port users(7) man page. The structure and the overall idea of these two pages are very similar; do you have some notes/advises that I can learn from this page and apply to users(7)?

I think that having everone that will receive the mail listed publically
is a Good Thing for transparency, but if this needs more discussion,
this is not the place, so remove lwhsu for now.

Can we abandon this.

Thank you so much for the reviews. These are tough issues actually.

update, thanks jhb!

Note: I separated out the whitespace and comment fixes before pushing.

@emaste you are correct / needs escaping in regex pattern groups.

Oh it looks like / needs to be escaped in the [] expression, so [.-\/]. I tried that expression locally and it looked OK but double check

Change the regex for both OSRELEASE and VOLUME_LABEL.

Oh yeah, of course -- I missed the . if !defined(${_V}) || empty(${_V}). So then the question is do we want to take the branch from Cirrus? I.e., is FreeBSD-16.0-CURRENT-amd64 desired, or FreeBSD-16.0-pull_1234-amd64?

In D54277#1240322, @emaste wrote:

This seems a bit strange - BRANCH should be coming out of newvers.sh and be something like BRANCH="CURRENT" (unless BRANCH_OVERRIDE is set). How is pull/XXXX making its way in?

I think CIRRUS-CI also has an environment variable named BRANCH.

This seems a bit strange - BRANCH should be coming out of newvers.sh and be something like BRANCH="CURRENT" (unless BRANCH_OVERRIDE is set). How is pull/XXXX making its way in?

Just in case I created PR and it was fired into our persistent worker.

In D54268#1240216, @alc wrote:

Since we are starting to expand the usage of vmem, I want to point out something that I only noticed around the time we added support for nextfit allocation. What we call bestfit is really an implementation of firstfit allocation. (A comment pointing this out was actually deleted from the Netbsd original when vmem was imported.) And, what we call firstfit is what, I believe, Solaris calls instantfit. We have no actual implementation of bestfit allocation. That said, mav's long ago change to "create own free list for each of the first 32 possible allocation sizes" has the effect of bestfit allocation for small sizes.

Here is the comment that got deleted:

	} else { /* VM_BESTFIT */
		/*
		 * we assume that, for space efficiency, it's better to
		 * allocate from a smaller block.  thus we will start searching
		 * from the lower-order list than VM_INSTANTFIT.
		 * however, don't bother to find the smallest block in a free
		 * list because the list can be very long.  we can revisit it
		 * if/when it turns out to be a problem.