I'm not sure how these assertions will be beneficial if we have to add them to every function of the ifp [un]linking.
IMHO, KASSERT/MPASS are existing to verify programmatic assumptions.
And yes, these changes are definitely verifies programmatic assumptions.
However, I don't think that using them to verify every programmatic assumptions per function is appropriate.

In D55682#1276464, @pouria wrote:

I've to apply your patch again and wait to see the new logs.
Will tell you.

LGTM, if there is any ports fallout it is easy to revert.

Ping? I would like to get this done sooner rather than later so the SeaBIOS port is functional again. Without this change the generated SeaBIOS firmware image is non-functional.

Garbage-collect a comment obsoleted by this change.

In D55682#1278294, @rkitover_gmail.com wrote:

Apologies if I'm being impatient, but when does the patch go into the tree?

Apologies if I'm being impatient, but when does the patch go into the tree?

If PKG_CREATE_THREADS_NUMBER is set by the user or port(?), there is no need to override it.
If it's undefined, then of course you need to set an explicit value for each known type, not "else == xz", but all unknowns will be in "else".
It would also be nice to be able to add custom compressor options. For example, use can to add -vv for xz to see the compression progress or -e.
By the way, I hope it is possible to specify a custom compressor? gzip, bzip2, lz4 etc.

I managed to test and my memory was correct though I couldn't find it Friday;
there's more sbufs out there which now need to be changes I assume, e.g., sys/compat/linuxkpi/common/src/linux_seq_file.c

I'm working on updating this to incorporate the suggestions from folks.

It is unclear to me if those .include <bsd.compiler.mk> lines is the right fix.

In D55867#1278215, @imp wrote:

What's the rush? 😄