The commit mentioned refers to this: https://github.com/freebsd/freebsd-src/pull/1905

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
library, not syscall.

The libusb_open issue is logged here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291774

D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access.
style(9) fix

D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access.
Narrow scope of the review.

In D54218#1240472, @ziaee wrote:

The doc should be changed in the commit that changes the behavior for many reasons, such as bisecting and downstream consumers.

The doc should be changed in the commit that changes the behavior for many reasons, such as bisecting and downstream consumers.

To avoid breaking existing users of distributekernel (which is what we
currently use to stage the kernel), reimplement stage-packages-kernel
to run make install itself rather than changing the existing behaviour
of distributekernel; this means release builds and other downstream
users are not affected by this change.

D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access.
Removing manpage changes because

1. clean up libusb.3 and libusb20.3 represents a lot of work that deserves a separate review review and
2. I don't want to invest that effort until I have buy-in that this change will go forward.

Smaller changesets are easier to review and merge.

In D54130#1240411, @dev_nicolas-provost.fr wrote:

If M_RX gets unset, the device file was closed, so no read will occur anymore and draining or keeping data is useless. I made a successful test with this extra lock/unlock.

How do we arrive at 0.4ms sleep though? What is the logic behind it? Is it just because it seems to work on your setup, or is there some calculation you used to arrive at it?

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
Replace Va with Fa.

add UPDATING

this is basically ready, but there are some unresolved issues:

Done!

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.

Updating libusb20_be_device_foreach.3 next.

D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages.
Move SEE ALSO after EXAMPLES.

Use strtonumx().

Use the same semantic for cklen as in the UDP case.

If M_RX gets unset, the device file was closed, so no read will occur anymore and draining or keeping data is useless. I made a successful test with this extra lock/unlock.

LGTM. For me I would extract a new variable like ${BRANCH_SAFE} (or a better name. I can't think of a good one right now) to run and hold the regexp processed result, for easier maintaining in the future.

I'm also going to port users(7) man page. The structure and the overall idea of these two pages are very similar; do you have some notes/advises that I can learn from this page and apply to users(7)?