In D35881#857696, @olivier wrote:

Thanks for the tips about checking for dying state: This is the root cause is. The jail is stuck forever in dying state after destroying (without even using) the vnet interface.

Take Dag-Erling's suggestions.

In D54374#1257737, @cperciva wrote:

Sorry, I completely forgot about this patch. Thanks for the ping.

Looking at the release.sh code, env_setup is called first from main and really should be called env_setup_default, and then the configuration provided via -c RELEASECONF is sourced. So I really don't see what needs to be changed.

style commented to use #ifdef without functional change.

Some other notes for reviewers: (see description above too please)

You're totally right. I grepped the doc repo just to be sure, and we don't have anything about using ${DEFAULT_VERSIONS}. If we had something (maybe in the handbook, as it's designed for end-users) we could reference it here instead maybe.

It also resolves one of the issues in PR263982.

Try this:

MASTER_SITES=   https://raw.githubusercontent.com/${GH_ACCOUNT}/${GH_PROJECT}/refs/tags/v2.12.4/snap/gui/:icons
DISTFILES=      ccViewer.png:icons cloudcompare.png:icons
DIST_SUBDIR=    ${PORTNAME}-${DISTVERSION}
EXTRACT_ONLY=   ${_DISTFILES:N*.png}

Don't forget make makesum.

Make the comment more terse

Handle feedback

In D55434#1268047, @vvd wrote:

Can you show direct links to *.png files?
I'll try to fix this.

Sure, I can:
https://github.com/CloudCompare/CloudCompare/tree/v2.12.4/snap/gui
https://github.com/CloudCompare/CloudCompare/blob/v2.12.4/snap/gui/ccViewer.png
https://github.com/CloudCompare/CloudCompare/blob/v2.12.4/snap/gui/cloudcompare.png
Hope you could do it, so I could learn from you. Even if not, I'll be glad you tried to help me :)

@royger Let me know if you'd like me to fix the signed-off-by line to avoid the mojibake, BTW. It looks like it was in the original Xen commit message and I didn't want to edit it without checking with you.