Use a separate variable called reduce_pos for the
reduction position, which is now calculated by the
NFS glue code, as suggested by Vinicius.

Not 100% confident, but that drm-kmod issue seems similar enough I think there's a decent chance this solves it. More testing would definitely be helpful

Welcome back!

Add kargl@ patch from PR 298260

If we reach the final cleanup without a new mr we may run in a non necessary second free request.

In D59462#1365021, @fuz wrote:

Oh yeah, using the archlevel framework sounds like a good idea! I didn't even think about that, as it's specific to libc. Other libm functions may profit in the future.

Restore the copyright header and please have a look at the other things, too.

I followed up on one of Sourojeet's reviews as we will likely how to commit his changes. Whether yours or his goes in for this particular one I leave up to you.

Thanks for the ping. So I dug in a little further. The existing description is actually aligned with a library, mktemp.3 which has the same description. It can make not only directories, but pipes and fifos and... (etc) which are all normalized to files. Further, mktemp was written by Todd C Miller and even has a website https://www.mktemp.org/ and seems to have the same Nd in every single OS because we're all using the same implementation. So, we should not change it. In fact perhaps it should be in contrib/ to make that more obvious but I do not want to grind that axe.

We may be missing the error treatment for the case where reduce_chp is NULL.

I think the right way to do things is to let you commit the CLASS code and then I will adjust the CLEANUP/GUARD code to match/use the CLASS code.

That was fast in drm-kmod :)

Recent changes to "fix" handling of retries introduced
the bug Vinicius spotted. It actually didn't break anything
for the non-retry case, since it just meant the "reduce" mbuf
wasn't removed from the copy of the mbuf request list.

Rick, there are some goto shenanigans happening.

I take it, this code fixes the problem reported here: https://github.com/freebsd/drm-kmod/pull/496 ? If it does, thank you very much for writing it! I'll test this code later.

Oh yeah, using the archlevel framework sounds like a good idea! I didn't even think about that, as it's specific to libc. Other libm functions may profit in the future.

Ah, thank you so much for doing this! I've been fixing the SYNOPSIS and HARDWARE one at a time :P

LGTM after moving the HARDWARE section heading up a bit. Thanks ngie!

Ping.

Ping.

Ping.

In D59406#1364025, @olce wrote:

Well, I don't find the new comment less vague. By contrast, the description you're giving in the current commit message is immediately intelligible.

But it is not completely true either: There is another caller of updatepri(): sched_wakeup(), which does not call decay_cpu() in advance. There is thus a probable bug with calling decay_cpu() only ts_slptime - 1 in all cases. I think updatepri() should just run the loop exactly ts_slptime always, and callers that need to adjust ts_slptime should do so before the call. But in fact no adjustment should be needed by rewriting the code in a clearer way.

For this revision, I'm OK with just updating the comment with a better stated version of what the author had in mind here. But then, what the comment means is in fact wrong, and should later be fixed along with the code.

In D58834#1357993, @jhb wrote:

I'm also working on merging changes to iw_cxgbe that should update it btw. For mthca we can find an upstream Linux commit to pull across. I think we should probably just move consumers to the newer KPI.

Hi,
sorry, I somehow assumed you have a commit bit. This is not the case, right? So @dumbbell , @emaste, or I need to commit your changes?

Rick, overall, it looks good, but theres a lot of code here. The only way to be sure is testing that.

Yes good catch, the flags is technically still there. I agree with you, and I saw it too that the change on the prototype in the comment should have been left for D5449 (where it is formally dropped). I thought let's keep it that way to avoid too much noise, and also because there was already an inconsistency between copy/copystr comment in this regard. In the end, they both need to check that a fault didn't happen. I can update this DR if you prefer having it 100% correct. I'd rather not bother now, but make sure that the Aarch32 copyout case if fixed as well in D59449 (where the IN/OUT are properly split apart, currently for aarch64 only), to explain why we don't need to pass the flags (for aarch32/aarch64 in the IN-direction and for aarch32 in the OUT direction), and align all the prototype definitions at once.

Add __unused after unused arguent in linuxkpi_hrtimer_dummy_timeout() as suggested by @bz.