remarks fixed.

Ok, but we're removing it from the base system, not the port.

… Don't make me share additional thoughts on the subject.

Add comment noting that the ESP is mounted.
Rename ZFS mirror loop variable so mntpt can be reused.

In D55454#1268412, @rrs wrote:

I dislike the term "hallucinated" since no, this is not a hallucination it is the AI LLM failing to read/interpret and build correct code. It's why AI is currently inferior. If I were
to write a bunch of code assuming that something existed because I did not bother to look at what I was writing to you would call that poor developer skills as
well as poor coding skills. With AI we say it "hallucinated", which is a crock, it just showed us its a poor developer with poor coding skills :-o

haven't done a hugely in-depth review yet. Overall looks pretty good!

In D55454#1268409, @tuexen wrote:

How would you handle the assoc_id for one-to-many style sockets? Also provide that in sockstat? How did it handle the fact that most IPPROTO_SCTP-level socket options have a struct as the option value?

In D55460#1269031, @rrs wrote:

The reason I am suggesting to include FIN WAIT 1/2 is that we stopped sending, but the
peer can send us data for an unlimited amount of time.. Shouldn't this data transfer towards
us be able to use ECN? That would mean we should send ACKs based on the received ECN markings.
Am I wrong with this? Why shouldn't half closed TCP connections not use ECN for the
direction data is still sent?

Hmm FIN WAIT 2, yes I can see that since at that point you have transitioned to fully closed. And yes
the peer could keep in established on its side a long time.. But are you not in the middle of your close
in FIN WAIT 1?

I like this, but version … version reads a little oddly.

I think this looks great! I have no notes for you :-)

This driver was supposed to be a port form Linux Apple IR driver.

BTW we're going to need this ASAP if it's going to land in 14.4.

Remove debug DPRINTFN calls and verbose NEC code comments

The port is still called cdialog.

Provide the full loader path as an argument, instead of just the file name.

This seems fine to me, although I had to do math using my fingers for the counting.

In D55469#1269123, @jrtc27 wrote:

What is the effect of this bug?

drop unneeded header

Thanks @adamw! I think that digging into the small stuff can make all
the difference! @linimon suggested "the big Kahuna", while historic,
is worthless and it's time to go. Here are the suggestions you made plus
an adaption of his suggestion for that.

I still need the non-x11@ maintainers a few days to accept this. Hopefully they wont make me file bugs to point to this.

I love this. Over to @jilles for the final say (and of course if anyone else has anything to say).

NB: It's also about to be in 14.4 via 829e479a0a37eb72023ce361f5b2379d82f8bc2a

update_uefi_bootentry assumes that the caller sets FREEBSD_BOOTNAME and
mntpt, which isn't the case anymore

Thank you

The FreeBSD Mall retiring is actually a big deal in the project's history. They've been supporting us for over two decades. A commit for their retirement needs to remove it from the whole doc tree at once, and have a nice little text about how this was meaningful and we appreciate them, and needs to mention that @cperciva spoke with them.

As far as I can tell Thomas E. Dickey just calls it dialog. cdialog appears in the "Early History" section in https://invisible-island.net/dialog/#history_details, in our ports tree, and in some tooling in the package to support renaming.

Will update commit message to make it clear we are installing bsd cpio unconditionally, not removing the option to install bsd cpio.

In D55424#1269013, @emaste wrote:

Why cdialog and not libdialog in the message?

Only enable if ext_dest_id is set to -1.

Only enable if ext_dest_id is set to -1.