Page MenuHomeFreeBSD
Differential D59941

apm(8): Remove support for APM BIOS
AcceptedPublic
Actions

Authored by jhb on Wed, Sep 23, 7:06 PM.
Tags
None
Referenced Files
F173151628: D59941.id187532.diff
Wed, Sep 23, 11:17 PM
F173150465: D59941.diff
Wed, Sep 23, 11:04 PM
F173149316: D59941.id187532.diff
Wed, Sep 23, 10:54 PM
F173149231: D59941.diff
Wed, Sep 23, 10:53 PM
Subscribers
ziaee

Details

Reviewers
imp
Summary

Drop support for queries and commands that are not supported by ACPI's
/dev/apm interface. This includes dropping support for
enabling/disabling APM BIOS used by /etc/rc.d/apm.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77224
Build 74107: arc lint + arc unit

Event Timeline

jhb created this revision.Wed, Sep 23, 7:06 PM
Herald added a subscriber: ziaee. · View Herald TranscriptWed, Sep 23, 7:06 PM
jhb requested review of this revision.Wed, Sep 23, 7:06 PM
jhb added a parent revision: D59940: acpi/apm: Store the ACPI softc in si_drv1.
Harbormaster completed remote builds in B77224: Diff 187532.Wed, Sep 23, 7:06 PM
jhb added a child revision: D59942: acpi: Remove support for /dev/apmctl and apmd(8) compatibility.Wed, Sep 23, 7:07 PM
jhb added a comment.Wed, Sep 23, 7:09 PM

Tested on my X1 Carbon which still outputs correct battery info.

imp accepted this revision.Wed, Sep 23, 9:09 PM
imp added inline comments.
usr.sbin/apm/apm.c
109

I'm glad to see you kept this sutff.... It's required for Emacs to display battery stuff right

This revision is now accepted and ready to land.Wed, Sep 23, 9:09 PM
ziaee added inline comments.Wed, Sep 23, 9:17 PM
usr.sbin/apm/apm.8
24–26

Can we have the introductory sentence explain what it is now, not what it was? I think this is more appropriate for HISTORY.

74

(or something)

ziaee added inline comments.Wed, Sep 23, 9:33 PM
usr.sbin/apm/apm.8
13

i386 is no more in 16.0 and this only works on amd64 now, right?

17

(or something)

Revision Contents
Changeset List

PathSize
3 lines
libexec/
rc/
rc.d/
6 lines
share/
man/
man5/
9 lines
tools/
build/
mk/
4 lines
usr.sbin/
apm/
74 lines
264 lines

Diff 187532

View Options

ObsoleteFiles.inc

Loading...
View Options

libexec/rc/rc.d/Makefile

Loading...
View Options

libexec/rc/rc.d/apm

Loading...
View Options

share/man/man5/rc.conf.5

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...
View Options

usr.sbin/apm/apm.8

Loading...
View Options

usr.sbin/apm/apm.c

Loading...