Differential D59939

acpi/apm: Don't claim silent success for APMIO_BIOS ioctls
ClosedPublic
Actions

Authored by jhb on Wed, Sep 23, 7:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 17, 7:19 AM

	Unknown Object (File)
	Sat, Oct 17, 6:20 AM

	Unknown Object (File)
	Wed, Oct 14, 4:19 AM

	Unknown Object (File)
	Wed, Oct 14, 4:10 AM

	Unknown Object (File)
	Sat, Oct 10, 4:09 PM

	Unknown Object (File)
	Sat, Oct 10, 4:03 PM

	Unknown Object (File)
	Sat, Oct 10, 2:10 AM

	Unknown Object (File)
	Sat, Oct 10, 2:04 AM

View All 47 Files

Subscribers

None

Details

Reviewers

Commits

rG42f4c37035ee: acpi/apm: Don't claim silent success for APMIO_BIOS ioctls
rG1d7f0c742863: acpi/apm: Don't claim silent success for APMIO_BIOS ioctls

Summary

Report failure as if the request had failed. This causes apm(8) to
correctly report the resume timer as "unknown" rather than random
garbage.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Wed, Sep 23, 7:06 PM

jhb created this revision.

jhb added a parent revision: D59938: apm.4: Trim down to describing the compat interface exposed by acpi(4).

Harbormaster completed remote builds in B77222: Diff 187530.Wed, Sep 23, 7:06 PM

jhb added a child revision: D59940: acpi/apm: Store the ACPI softc in si_drv1.Wed, Sep 23, 7:06 PM

Verified that apm(8) on my X1 Carbon no longer outputs garbage for the resume timer state with this fix.

imp accepted this revision.Wed, Sep 23, 9:10 PM

This revision is now accepted and ready to land.Wed, Sep 23, 9:10 PM

Closed by commit rG1d7f0c742863: acpi/apm: Don't claim silent success for APMIO_BIOS ioctls (authored by jhb). · Explain WhyWed, Sep 30, 4:27 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1d7f0c742863: acpi/apm: Don't claim silent success for APMIO_BIOS ioctls.

jhb added a commit: rG42f4c37035ee: acpi/apm: Don't claim silent success for APMIO_BIOS ioctls.Thu, Oct 8, 8:45 PM

Revision Contents
Changeset List

Path

Size

sys/

x86/

acpica/

3 lines

Diff 188217

sys/x86/acpica/acpi_apm.c

Loading...