Page MenuHomeFreeBSD
Differential D59939

acpi/apm: Don't claim silent success for APMIO_BIOS ioctls
AcceptedPublic
Actions

Authored by jhb on Wed, Sep 23, 7:06 PM.
Tags
None
Referenced Files
F173751128: D59939.diff
Mon, Sep 28, 3:14 AM
F173636458: D59939.diff
Sun, Sep 27, 8:46 AM
Unknown Object (File)
Thu, Sep 24, 9:01 PM
Unknown Object (File)
Thu, Sep 24, 3:43 PM
Unknown Object (File)
Thu, Sep 24, 8:30 AM
Unknown Object (File)
Thu, Sep 24, 6:40 AM
Unknown Object (File)
Thu, Sep 24, 2:19 AM
Unknown Object (File)
Wed, Sep 23, 11:26 PM
View All 11 Files
Subscribers
None

Details

Reviewers
imp
Summary

Report failure as if the request had failed. This causes apm(8) to
correctly report the resume timer as "unknown" rather than random
garbage.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77222
Build 74105: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Wed, Sep 23, 7:06 PM
jhb created this revision.
jhb added a parent revision: D59938: apm.4: Trim down to describing the compat interface exposed by acpi(4).
Harbormaster completed remote builds in B77222: Diff 187530.Wed, Sep 23, 7:06 PM
jhb added a child revision: D59940: acpi/apm: Store the ACPI softc in si_drv1.Wed, Sep 23, 7:06 PM
jhb added a comment.Wed, Sep 23, 7:09 PM

Verified that apm(8) on my X1 Carbon no longer outputs garbage for the resume timer state with this fix.

imp accepted this revision.Wed, Sep 23, 9:10 PM
This revision is now accepted and ready to land.Wed, Sep 23, 9:10 PM

Revision Contents
Changeset List

PathSize
sys/
x86/
acpica/
3 lines

Diff 187530

View Options

sys/x86/acpica/acpi_apm.c

Loading...