Page MenuHomeFreeBSD

Fix multiple bugs with ctld's UCL parsing
AbandonedPublic

Authored by asomers on Dec 26 2023, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 28, 8:02 PM
Unknown Object (File)
May 10 2024, 11:35 AM
Unknown Object (File)
May 9 2024, 6:36 PM
Unknown Object (File)
May 9 2024, 6:27 PM
Unknown Object (File)
May 9 2024, 3:54 AM
Unknown Object (File)
Apr 14 2024, 8:01 AM
Unknown Object (File)
Feb 18 2024, 8:21 PM
Unknown Object (File)
Jan 10 2024, 9:42 AM

Details

Reviewers
andrew
jilles
slm
manu
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
transport
bhyve
cam
Summary
  • Don't segfault when parsing a misformatted auth-group section
  • If the config file specifies a chap section within a target but no auth-group, create a new anonymous auth-group. That matches the behavior with non-UCL config files.
  • Protect some potential segfaults with assertions

PR: 274380
MFC after: 1 week
Sponsored by: Axcient

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errorlib/libc++/Makefile:NAME1Bad Filename
Warningtests/sys/net/if_bridge_test.sh:CHMOD1Invalid Executable
Unit
No Test Coverage
Build Status
Buildable 55125
Build 52014: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 26 2023, 7:06 PM

Oops. I accidentally included way too many commits. I'll close this review and start over.