Page MenuHomeFreeBSD

ktls: Fix races that can lead to double initialization
ClosedPublic

Authored by markj on Jun 21 2024, 4:48 PM.
Tags
None
Referenced Files
F108607826: D45674.id140697.diff
Sun, Jan 26, 8:34 PM
F108594165: D45674.id140075.diff
Sun, Jan 26, 6:16 PM
Unknown Object (File)
Fri, Jan 24, 5:54 PM
Unknown Object (File)
Wed, Jan 15, 3:40 PM
Unknown Object (File)
Sat, Jan 11, 10:06 PM
Unknown Object (File)
Sun, Jan 5, 9:18 AM
Unknown Object (File)
Dec 8 2024, 1:46 PM
Unknown Object (File)
Nov 15 2024, 12:22 AM
Subscribers

Details

Summary

ktls_enable_rx() and ktls_enable_tx() have checks to return EALREADY if
the socket already has KTLS enabled. However, these are done without
any locks held and nothing blocks concurrent attempts to set the socket
option. I believe the worst outcome of the race is leaked memory.

Fix the problem by rechecking under the sockbuf lock. While here,
unify the locking protocol for sb_tls_info: require both the sockbuf and
socket I/O locks in order to enable KTLS. This means that either lock
is sufficient for checking whether KTLS is enabled in a given sockbuf,
which simplifies some refactoring further down the road.

Note that the SOLISTENING() check can go away because
SOCK_IO_RECV_LOCK() atomically locks the socket buffer and checks
whether the socket is a listening socket. This changes the errno value,
so update a test which checks it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable