Thanks! Lemme test it locally and then i'll pull it into -head.

Hi rkitover,

zlei, I updated the axe and ure patches based on your review.

A couple of minor style(9) fixes

I've made the changes you suggested zlei, I will update the axe and ure patches as well.

Style fixes based on zlei's review

Style fixes based on zlei's review

In D55631#1285161, @kevlo wrote:

In D55631#1284650, @bms wrote:

I was able to obtain an axge(4) compatible USB3 adapter for ~6GBP from Amazon.

Is the chipset ax88279? If so, could you send me the link to the product so
I can buy one? Thanks.

Do you know of other drivers that would benefit from this patch that you have access to hardware for?

PS: I bought a USB adapter ( AX88179A ) but were not able to repeat ( with stress tests for about two days ).

In D55631#1284650, @bms wrote:

I was able to obtain an axge(4) compatible USB3 adapter for ~6GBP from Amazon.

Hi bms,

I was able to obtain an axge(4) compatible USB3 adapter for ~6GBP from Amazon.

Hi sanpei,

I have tested the updated if_axge driver with several devices.
In my environments, the issues with link flaps have been resolved(even added changing axge_miibus_statchg, there is "no" spurious link down message. Same as axe I don't know why??) .

Posted patch to lock MII bus:

FYI
I have created and am currently testing a patch that includes "Lock-mii-bus-operation" for 15.0-RELEASE. (Link: patch)
I ported some parts from the axge driver (specifically the changes around ure_attach at line 515).

I have tested the ure driver across several environments. Here are the results:

Add lock to serialize MII bus operations

I posted the axe patch:

Hi Adrian,

this is good work! i would like to figure out how to describe the "why" this extra stuff is necessary though, so lemme noodle on that a bit first.

LGTM

Another style(9) update

I have confirmation from someone in the bug thread that the patch works:

Thank you pouria!

In D55682#1276464, @pouria wrote:

I've to apply your patch again and wait to see the new logs.
Will tell you.

In D55682#1278294, @rkitover_gmail.com wrote:

Apologies if I'm being impatient, but when does the patch go into the tree?

Apologies if I'm being impatient, but when does the patch go into the tree?

Updated per review: deleted the 4 commented-out struct members from if_rgevar.h (if_rxring, pci_intr_handle_t, pci_chipset_tag_t, pcitag_t) instead of just converting their comment style.

Lemme see which I can delete and which I need to keep and use.

Remove frozen TX handling, unneeded if link up

I think I can remove the frozen TX fix given that the link doesn't go down, I'll do that and test it out, then update this patch.

Update for style(9)

Fix for style(9)

In D55682#1276829, @rkitover_gmail.com wrote:

Sorry about the style violations, I will read the guide more carefully and adjust both DRs.