Thanks for the hint! The bad distfile name really bothered me, but I couldn't figure it out on my own.

2023-04-07 (and newer) results for Vulkan on X11 (both Xwayland and Xorg) are too low like during software rendering. Seems to be limited to --fullscreen option. Likely a drm-kmod regression as mesa-devel-21.2.b.284 no longer works (VK_ERROR_DEVICE_LOST) without either ANV_QUEUE_THREAD_DISABLE=1 or mesa@d2ff2b9e4a22 and still exhibits low performance as new versions.

Abandoning as I lack mental energy to respond to possible comments, and I'm probably no longer interested in FreeBSD.
This has nothing to do with this review, this is just accumulated. Feel free to pickup the revision if you are interested.

Abandoning this, since these changes should be superseded by the update of xserver to 1.20.

I believe this patch has been superseeded by the update of xserver to 1.20.

I don't think that Assistant key should be mapped to KEY_RIGHTMETA for following reasons:

1. It is not really a meta key as it does not affect other key meanings like Shift, Alt, Ctrl and Win keys do.
2. According to https://www.win.tue.nl/~aeb/linux/kbd/scancodes-6.html, scancode of 0x58 prefixed with 0xE0 is emitted by pressing of Fn+F12 keys on Logitech and Microsoft keyboards so the best matching evdev event would be KEY_FN_F12.

What's missing to get this in?

Update comment in Mk/Uses/gl.mk to reflect reality.

Updated based on latest set of comments.

In D16774#362352, @antoine wrote:

bsd.port.pre.mk / bsd.port.post.mk must be kept for the ${COMPILER_TYPE} check

bsd.port.pre.mk / bsd.port.post.mk must be kept for the ${COMPILER_TYPE} check

Updated diff with changes based on the latest round of comments.

I think USE_GL not defined should be forbidden.

Updated with latest round of comments.

Thank you!

Updated patch to also change the xorgproto dependency. Previously, we looked for one of the .pc files installed by xorgproto, this changes the dependency to actually depend on the port, since it installs so many .pc files.

Updated patch with a DEV_WARN if USE_GL is set without USES=gl.

I've updated the patch to take into account the comments in the review.

Update patch to ports tree r453973

Update diff to latest ports tree snapshot.

Removed wrong stanza modifying OPTIONS_DEFAULTS depending on external variable.

Thanks for the heads up!

Updated patch.

Yes, I suggest you try the latest patch in PR196678 . Yes, your patch is simple, but the matter is a bit more deeper than this :-)

In D9512#196789, @hselasky wrote:

This patch is a duplicate of:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196678

Have you tried the solution mentioned in the PR above?

This patch is a duplicate of:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196678

Obsolete due to 11.0 release.