Paths

Table of Contentst

Differential D21565

atkbd,evdev: Interpret Google Assistant key on Chromebooks as right meta
AbandonedPublic
Actions

Authored by val_packett.cool on Sep 8 2019, 2:59 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 7:45 PM

	Unknown Object (File)
	Fri, Dec 13, 1:34 AM

	Unknown Object (File)
	Mon, Dec 9, 1:02 AM

	Unknown Object (File)
	Sat, Dec 7, 7:57 AM

	Unknown Object (File)
	Mon, Dec 2, 12:02 AM

	Unknown Object (File)
	Nov 22 2024, 5:19 AM

	Unknown Object (File)
	Nov 20 2024, 12:37 PM

	Unknown Object (File)
	Nov 20 2024, 12:37 PM

View All 65 Files

Subscribers

Details

Reviewers

Group Reviewers

Contributor Reviews (src)

Summary

The Google Pixelbook has an Assistant key where the Win key usually is. It sends the 0x58 scancode that we didn't interpret as anything at all.

The search key (capslock) is left meta already, so let's interpret this as right meta I guess.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

val_packett.cool created this revision.Sep 8 2019, 2:59 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 8 2019, 2:59 PM

emaste added a subscriber: emaste.Oct 7 2019, 6:43 PM

lwhsu added a reviewer: wulf.Dec 19 2019, 11:28 AM

I don't think that Assistant key should be mapped to KEY_RIGHTMETA for following reasons:

It is not really a meta key as it does not affect other key meanings like Shift, Alt, Ctrl and Win keys do.
According to https://www.win.tue.nl/~aeb/linux/kbd/scancodes-6.html, scancode of 0x58 prefixed with 0xE0 is emitted by pressing of Fn+F12 keys on Logitech and Microsoft keyboards so the best matching evdev event would be KEY_FN_F12.

IMO we can add all 12 KEY_FN_FX evdev events as e0 variation of the ordinary or FX keys

wulf mentioned this in rS360624: [evdev] Add AT translated set1 scancodes for F-unlocked F1-12 keys..May 4 2020, 10:59 AM

val_packett.cool abandoned this revision.May 4 2020, 3:57 PM

wulf mentioned this in rS362206: MFC r360624:.Jun 15 2020, 10:33 PM

wulf mentioned this in rS362207: MFC r360624:.Jun 15 2020, 10:36 PM

Revision Contents
Changeset List

Path

Size

		sys/	dev/
	i/	sys/	dev/

atkbdc/

5 lines

evdev/

4 lines

Diff 61806

sys/dev/atkbdc/atkbd.c

Loading...

sys/dev/evdev/evdev_utils.c

Loading...