Page MenuHomeFreeBSD

atkbd,evdev: Interpret Google Assistant key on Chromebooks as right meta
AbandonedPublic

Authored by greg_unrelenting.technology on Sep 8 2019, 2:59 PM.

Details

Reviewers
wulf
Group Reviewers
Contributor Reviews (base)
Summary

The Google Pixelbook has an Assistant key where the Win key usually is. It sends the 0x58 scancode that we didn't interpret as anything at all.

The search key (capslock) is left meta already, so let's interpret this as right meta I guess.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

I don't think that Assistant key should be mapped to KEY_RIGHTMETA for following reasons:

  1. It is not really a meta key as it does not affect other key meanings like Shift, Alt, Ctrl and Win keys do.
  2. According to https://www.win.tue.nl/~aeb/linux/kbd/scancodes-6.html, scancode of 0x58 prefixed with 0xE0 is emitted by pressing of Fn+F12 keys on Logitech and Microsoft keyboards so the best matching evdev event would be KEY_FN_F12.

IMO we can add all 12 KEY_FN_FX evdev events as e0 variation of the ordinary or FX keys