(and subsequent commits should use these defines instead of hard-coded strings..)

It would make sense to broaden their use, with bare string literals also being used in vfs_copyopt and vfs_setopt calls.

Now that I think about it, jail(8) and jls(8) code is also rife with these strings.

In D59572#1366963, @jamie wrote:

Now that I think about it, jail(8) and jls(8) code is also rife with these strings.

Right; we can fix those but after this commit. This commit doesn't change their values, it just adds a level of indirection to them.

nooooo please do the userland refactor as a follow-up commit. The kernel refactor doesnt change the string contents at all.

In D59572#1366964, @adrian wrote:

Right; we can fix those but after this commit. This commit doesn't change their values, it just adds a level of indirection to them.

I was testing the world , that why i pushed the version bump. I reverted the version bump.

The headers only didn't need it, but now we have the full refactoring.

This change also can be backported to 15.

In D59572#1366984, @adrian wrote:

nooooo please do the userland refactor as a follow-up commit. The kernel refactor doesnt change the string contents at all.

Ok.

In D59572#1366987, @seuros wrote:

In D59572#1366964, @adrian wrote:

Right; we can fix those but after this commit. This commit doesn't change their values, it just adds a level of indirection to them.

I was testing the world , that why i pushed the version bump. I reverted the version bump.

Can you expand on this a little more? You shouldn't have needed a version bump for buildworld, for instance, because clang should have emitted the header as a dependency that bmake acknowledges would made the including object files out of date (even without metamode or anything fancy)?

Can you expand on this a little more? You shouldn't have needed a version bump for buildworld, for instance, because clang should have emitted the header as a dependency that bmake acknowledges would made the including object files out of date (even without metamode or anything fancy)?

right, but the bump for my workspace, i had other unrelated commit prior that needed invalidation.
So when i was asked to push a fix, i committed that extra local file by mistake.