Page MenuHomeFreeBSD
Differential D44103

conf: deduplicate dwc config logic
ClosedPublic
Actions

Authored by mhorne on Feb 27 2024, 5:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 1:26 AM
Unknown Object (File)
Sun, Sep 6, 11:35 PM
Unknown Object (File)
Sat, Sep 5, 6:58 AM
Unknown Object (File)
Fri, Sep 4, 4:29 PM
Unknown Object (File)
Fri, Sep 4, 3:07 PM
Unknown Object (File)
Thu, Sep 3, 1:31 PM
Unknown Object (File)
Thu, Sep 3, 3:17 AM
Unknown Object (File)
Wed, Sep 2, 2:11 PM
View All Files
Subscribers
emaste
imp
jrtc27

Details

Reviewers
manu
andrew
Group Reviewers
arm64
riscv
Commits
rGa01dc140b27e: conf: deduplicate dwc config logic
Summary

Move the core dwc(4) file entries to the MI conf/files.
Platform-specific versions e.g. rk_dwc are retained in their current
position. On arm64 this necessitates adding an additional 'device dwc'
option.

This hardware is found on several available/emerging RISC-V SoCs, so we
will soon need it on this architecture. Add it to LINT for now.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56276
Build 53164: arc lint + arc unit

Event Timeline

mhorne created this revision.Feb 27 2024, 5:57 PM
Herald added a reviewer: andrew. · View Herald TranscriptFeb 27 2024, 5:57 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
mhorne requested review of this revision.Feb 27 2024, 5:57 PM
Harbormaster completed remote builds in B56276: Diff 135082.Feb 27 2024, 5:57 PM
jrtc27 added a subscriber: jrtc27.Feb 27 2024, 6:03 PM
jrtc27 added inline comments.
sys/riscv/conf/NOTES
61

This seems like a separate change?

mhorne added inline comments.Feb 27 2024, 6:09 PM
sys/riscv/conf/NOTES
61

Yeah, you are right. I will split this out before commit, same goes for dwmmc addition in D44104.

jrtc27 added inline comments.Feb 27 2024, 6:10 PM
sys/riscv/conf/NOTES
61

Ok. I think it's fine to merge the two riscv dwc* changes into one commit though if you want to, though commits are cheap.

manu accepted this revision.Feb 27 2024, 6:16 PM
This revision is now accepted and ready to land.Feb 27 2024, 6:16 PM
Closed by commit rGa01dc140b27e: conf: deduplicate dwc config logic (authored by mhorne). · Explain WhyFeb 27 2024, 10:11 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rGa01dc140b27e: conf: deduplicate dwc config logic.

Revision Contents
Changeset List

PathSize
sys/
arm64/
conf/
1 line
1 line
1 line
conf/
4 lines
4 lines
4 lines
riscv/
conf/
1 line

Diff 135082

View Options

sys/arm64/conf/NOTES

Loading...
View Options

sys/arm64/conf/std.altera

Loading...
View Options

sys/arm64/conf/std.rockchip

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/conf/files.arm

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/riscv/conf/NOTES

Loading...