Today
I did a survey of GCE's bare metal machine series, as well as internal checking. All of them show smbios.system.serial of the form GoogleCloud-BM-${uuid}, as opposed to GoogleCloud-${uuid} for non-bare-metal VMs.
Please fixs those on CURRENT. For this MFC, LGTM.
I suppose, review from native English speaker is needed, otherwise it looks almost perfect!
Please take into consideration that the changes discussed in this review are already present in the main branch (16.0-CURRENT). Escalating demands here is pointless. If the man page requires fixes, the right approach would be to fix it in the main branch and then MFC those changes to stable/15 (if this review ever lands in stable/15).
Rebase to latest main
Comma is preferred.
Looks good to me.
Effort: CHERI upstreaming or whatever it is seems like it would apply?
fix man page
Yesterday
Handle kib's comments.
committed in f57e7a549b08
going with ivy's opinion on this. thanks!
Fix manual style/warning nits
Fix some style(9) nits.
I agree with Ed on all of these points.
Hopefully the final touches
I think citing rfc4291 section 2.5.2 for the commit message would then make us consider removing this alltogether?
Will MFC to 13 and 14 tonight or tomorrow.
Panel Used By
| Dashboard | abemcintyre66_gmail.com's Dashboard |