Thanks @kbowling, that's a lot clearer!

Approved.

Approved.

use arrowd's suggestion, looks great and still fits in one line, thanks!

Made ext_dest_id static

Improve language for UPDATING and CHANGES, which also kicks the exclaimation mark out a bit father to catch the eye more.

Adjusted include guard to _X86_BHYVE_H_ instead of _BHYVE_H_

Overall I am fine with it, provided suggestions about the master driver and kmod

Sort tables into:

• ports root directory
• port root directory
• fs root directory

Thank you! This work wonderful, like a real magic! :)

Split FILES into sections arranged by root directory, so that CHANGES and UPDATING can be at the top, but we can still give this table more structure.

Move linuxulator port back to parenthetical quotes, matching other linuxulator ports.

we don't have anything about using ${DEFAULT_VERSIONS}.

In D35881#857696, @olivier wrote:

Thanks for the tips about checking for dying state: This is the root cause is. The jail is stuck forever in dying state after destroying (without even using) the vnet interface.

Take Dag-Erling's suggestions.

In D54374#1257737, @cperciva wrote:

Sorry, I completely forgot about this patch. Thanks for the ping.

Looking at the release.sh code, env_setup is called first from main and really should be called env_setup_default, and then the configuration provided via -c RELEASECONF is sourced. So I really don't see what needs to be changed.

style commented to use #ifdef without functional change.

Some other notes for reviewers: (see description above too please)

You're totally right. I grepped the doc repo just to be sure, and we don't have anything about using ${DEFAULT_VERSIONS}. If we had something (maybe in the handbook, as it's designed for end-users) we could reference it here instead maybe.

It also resolves one of the issues in PR263982.

Try this:

MASTER_SITES=   https://raw.githubusercontent.com/${GH_ACCOUNT}/${GH_PROJECT}/refs/tags/v2.12.4/snap/gui/:icons
DISTFILES=      ccViewer.png:icons cloudcompare.png:icons
DIST_SUBDIR=    ${PORTNAME}-${DISTVERSION}
EXTRACT_ONLY=   ${_DISTFILES:N*.png}

Don't forget make makesum.

Make the comment more terse

Handle feedback