Looks good to me.

The change looks good to me. Just a minor thing about portsnap options...

OK from manpages.

Looks better to me, yes. Go ahead! Thank you.

Good catch. I'll take care of it.

OK from manpages.

Ready to commit!

The man page looks good now, thanks!

Sure, looks good to me now. Thanks for making that change!

Oh yes, I have the same option on my NFS machines, too. Thanks for the fix.

Good to go now, thank you!

Looks good, thanks for yet another example.

Minor nit.

Approved!

Sure, go ahead. Thank you!

OK for the doc side of the change.

No worries, good things take time. Speaking of time: the time ha come to commit it. ;-)
Thank you!

The use of "you" is discouraged, see https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style.html.
I think it shortens the sentences a bit. I've marked some other minor mistakes. In general, I like the example and it's a great addition to the man page.

Good one, approved!

OK from manpages. A useful feature, I might add.

Looks good, approved for commit. Thank you!

Minor grammo found.

Looks good from manpages, can't say much about the actual code change, though.

Any updates here? The change seems simple enough to have. You can check your docs change using textproc/igor (it will tell you about the empty line after the <title> tag).

Can you check the manpage with textproc/igor and "mandoc -Tlint" to see if they find anything?
Thank you!

Looks good to me now, thanks!

Thanks for working on this PR, I think with the changes from @debdrup it is much better now and good to go into the handbook.

OK from manpages.

Looks good to me, approved! Thanks for writing the man page.

Looks good, sorry for the delay.

Approved (although I'm not so sure about the SCSI part, but I'll go with the spirit of the example given, not the actual technology used).

Looks good, ready to commit.

Looks good, approved! Thanks for working on it.

Good to go.

ping?

Good to go.

Looks good, approved!

Good to go. Thanks for taking care if it.

Ah yes, this looks better. Aproved!

Minor nit.

Looks good to me now, although I would use amd64 in the example as i386 is going the way of the dodo. But it does not matter much for the example.

Some suggestions for improvement...

Looks good from the doc side of things.

OK, thanks for these assessments.
@gbe: Can you either update the diff or close the PR if you think that is better than changing the existing text (just for the process= part)? For example, it could be "not a bug".

Do you guys have more insights into the 4k vs. 1M thing? There seems to be a lot of guessing and "from my experience" in the bug report which should be confirmed (or refuted) by someone more familiar with the code and/or I/O layer.

Looks good to me, thanks!

OK from manpages.

In D25492#563613, @carlavilla wrote:

In D25492#563586, @imp wrote:

In D25492#563565, @carlavilla wrote:

I don't know how I couldn't remember ... you just have to escape the character, instead of _ use \_

Cool. Are you doing that?

Yes, I'm using this and works well. This week I'm going to show all the articles converted to Hugo/AsciiDoctor and the next week I'll start with the books :)

Looks good and is a nice addition to the man page.

Also good by manpages. Thanks for this change!

Now the error went away... Strange, maybe a Phabricator hiccup. Anyway, this change is easy and hereby approved!

I get this exception when I load this review in Phabricator:

Adding Warner for comments on nanoBSD. I see no problems with these changes personally.

That's OK by me. It serves the same purpose essentially.

Manpages is also fine, just bump the .Dd before the commit. Thanks!

Looks good to me.

Good to go now, thanks!

I'm good with this change, thanks for working on it.
I'd wait a few more days to give other doceng members a chance to comment.

I'm good with that, sorry for missing that earlier.

Looks good, ready to go!

I just saw this now, it's fine.

@manu: Can you take care of this? Thanks!

Great, thanks for those quick fixes. OK form manpages.

Thank you for your change, looks like a useful feature.
I've made some comments on the man page. You can also use textproc/igor and "mandoc -Tlint" for further checks.

I love this sort of change. I've always been stumped at how long the website was building and seeing those old news float by during the build certainly wasn't making sense. I didn't look into how we could shorten the build by archiving the oder news though. But not I see it has been done before, so having this change is good and the 5 year period for old news seems reasonable to me. Thanks a bunch!

I love having an nginx section in the handbook, thanks for that initial writeup.
I've only a minor style issue to report. Maybe textproc/igor will find something...

That's a good catch, approved!

In D25266#559123, @salvadore wrote:

Also, can someone please point me to some documentation about MFC on the base tree? I can't find any which is complete enough.

In particular, I think it is safe to set MFC after: 1 week for this patch, isn't it? I don't break compatibility, most recent commits I saw set MFC after: 1 week and I don't think this patch requires more.

Alright, good to go.

Approved!

OK from manpages.

You can always re-open the revision.
@0mp: Sure, Dq is better. Sorry I missed that, causing extra work.

Excellent, now it's ready to land. Thank you!

Good to go, thanks for taking care of it.

Almost there...

Good to go from manpages. Thanks for the update.

Looks good to me.

Two suggestions...

OK, you can commit that. Thanks!

Good to go (with bumps of the .Dd to the date of the commit).

t looks good to me with the lowercase "to", so I'll commit it as is.