Page MenuHomeFreeBSD

Add Caveats Section to fgetln(3)
Needs ReviewPublic

Authored by gbergling_gmail.com on Tue, May 19, 1:53 PM.

Details

Reviewers
None
Group Reviewers
manpages
Summary

Add a Caveats Section to fgetln(3)

Obtained from: OpenBSD

Test Plan

mandoc output review

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 31178
Build 28839: arc lint + arc unit

Event Timeline

gbergling_gmail.com requested review of this revision.Tue, May 19, 1:53 PM
gbergling_gmail.com created this revision.
yuripv added a subscriber: yuripv.Tue, May 19, 2:04 PM
yuripv added inline comments.
lib/libc/stdio/fgetln.3
142

Nitpicking: != NULL, per style(9), "Test pointers against NULL"

jilles added a subscriber: jilles.Tue, May 19, 8:28 PM

Although there is nothing wrong with this per se, applications can deal with this problem more easily using getline(3) (which is also standard).

bcr added a subscriber: bcr.Wed, May 20, 7:07 AM

Although there is nothing wrong with this per se, applications can deal with this problem more easily using getline(3) (which is also standard).

We could mention this (the reference to getline(3)) in that section.