Page MenuHomeFreeBSD

vis(1): Add EXAMPLES section
ClosedPublic

Authored by fernape on Jun 12 2020, 7:26 AM.

Details

Summary
  • Add three examples showing the use of -h, -l, -t, -w

Sorry, this is a tricky one to review due to all the double scapes and such.

Test Plan
  • mandoc -Tlint clean
  • igor clean except for the use of "don't" in line 91. I do not know the policy for contractions.
  • aspell happy
  • man ./vis.1 renders the page properly

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I have an open differential https://reviews.freebsd.org/D23893 which synchronizes NetBSD changes with our version. Maybe our efforts can be joined. Could you try to integrate my differential first and then apply your manpage updates upon it?

In D25242#556485, @gbe wrote:

I have an open differential https://reviews.freebsd.org/D23893 which synchronizes NetBSD changes with our version. Maybe our efforts can be joined. Could you try to integrate my differential first and then apply your manpage updates upon it?

Sure thing, I can try later today. Where would the merge be updated? In this review (D25242) or in yours (D23893)?

Once https://reviews.freebsd.org/D23893 is committed you just have to rebase your differential. So we have the new examples section with the latest version of VIS. And after the commit, don't forget the sending your diff to the NetBSD folks. :)

In D25242#556821, @gbe wrote:

Once https://reviews.freebsd.org/D23893 is committed you just have to rebase your differential. So we have the new examples section with the latest version of VIS. And after the commit, don't forget the sending your diff to the NetBSD folks. :)

OK.

Note I'm not an src or docs committer though, I would need this review approved first ;-)

bcr added a subscriber: bcr.

Looks good, sorry for the delay.

This revision is now accepted and ready to land.Jul 16 2020, 2:01 PM
In D25242#568441, @bcr wrote:

Looks good, sorry for the delay.

No worries, thanks a lot for reviewing. I'm waiting for D25358 to be committed first, though.

@imp would you approve this as direct commit to contrib?

There is still https://reviews.freebsd.org/D25358 pending for a vendor import, but these examples are a good addition for the man page.

Looks reasonable, Shouldn't cause too much grief for merging from the successors of our former upstream...

LGTM

@fernape please forward this diff to christos@netbsd.org if you have some time.

This revision was automatically updated to reflect the committed changes.