Page MenuHomeFreeBSD

Sync vis(1) with NetBSD
AbandonedPublic

Authored by gbe on Feb 29 2020, 3:26 PM.

Details

Summary

Sync vis(1) with NetBSD

Test Plan

make in the vis directory

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29691
Build 27543: arc lint + arc unit

Event Timeline

Could someone review this one? There already changes to the vis manpage that depend on this one.

https://reviews.freebsd.org/D25242

This revision is now accepted and ready to land.Jun 12 2020, 2:32 PM

OK

Thanks. Could you commit this differential?

This differential is already approved. It would be very kind if a src committer could just commit it. :)

In D23893#558720, @gbe wrote:

This differential is already approved. It would be very kind if a src committer could just commit it. :)

I think you can commit it with your doc bit with @emaste 's approval. :-)

In D23893#558720, @gbe wrote:

This differential is already approved. It would be very kind if a src committer could just commit it. :)

I think you can commit it with your doc bit with @emaste 's approval. :-)

@emaste, what do you think?

@gbe indeed you can commit to src with approval from any src committer, however I noticed after that this code comes from vendor/NetBSD/vis, so we will want to import the update there and merge to contrib/

I'm happy to help you through the process if you're comfortable taking it on, but the process will change completely with the transition to git in a few months so I can just update there if you prefer.

@gbe indeed you can commit to src with approval from any src committer, however I noticed after that this code comes from vendor/NetBSD/vis, so we will want to import the update there and merge to contrib/

I'm happy to help you through the process if you're comfortable taking it on, but the process will change completely with the transition to git in a few months so I can just update there if you prefer.

I'll already did this once, so it wouldn't be that hard to replay this workflow to a vendor branch at https://svnweb.freebsd.org/base/vendor/NetBSD/vis/dist/. Doing the merge via svn is off course a step that needs attention. I only have done so in a not FreeBSD environment, but the committers handbook should be very helpful.

I'll have a look at the NetBSD sources and provide a new differential for the approval for the vendor branch import. (to say, a flattened import for the vendor branch's ../NetBSD/vis/dist directory, which, could be easly be integrated into contrib/).