Page MenuHomeFreeBSD

Sync vis(1) with recent NetBSD sources
Needs ReviewPublic

Authored by gbe on Jun 19 2020, 11:06 AM.

Details

Reviewers
emaste
lwhsu
Group Reviewers
manpages
Src Committers
Summary

Sync vis(1) with recent NetBSD sources.

This differential replaces https://reviews.freebsd.org/D23893, which was a direct update to the src repository.

Test Plan

make in the vis directory, after a merge from vendor -> src

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31825
Build 29385: arc lint + arc unit

Event Timeline

gbe requested review of this revision.Jun 19 2020, 11:06 AM
gbe added a reviewer: Src Committers.
bcr added inline comments.
vis.1
140

s/non-white space/non-whitespace/
(I'm thinking we should add this to our word list here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-word-list.html)

gbe planned changes to this revision.Jun 19 2020, 12:21 PM
gbe added a subscriber: fernape.

Address the comments.

vis.1
140

This is a vendor import. I would just wait to get this into -CURRENT and then fix the manpage towards to our standards. There is also a manpage update pending by @fernape that adds an example section to the manpage, which, should after the manpage update also been send upstream.

gbe requested review of this revision.Jun 27 2020, 7:32 AM
gbe marked an inline comment as done.

@emaste like requested, this is a vendor import of the recent vis sources.

Could someone review and maybe commit this?

@emaste, would it be okay if I commit this?

I would update the vendor sources first and then I would use the usual 'svn copy' method to do the merge from the vendor branch.

@emaste is there anything I can do to get this committed?

@emaste any change that this can be committed before the switch to git?

In D25358#618884, @gbe wrote:

@emaste any change that this can be committed before the switch to git?

Nope. It will have to wait. Your reward for eating, though, is that I'd be happy to do the import to test the process for real once things open again.

In D25358#618885, @imp wrote:
In D25358#618884, @gbe wrote:

@emaste any change that this can be committed before the switch to git?

Nope. It will have to wait. Your reward for eating, though, is that I'd be happy to do the import to test the process for real once things open again.

OK, even if I don't understand the phrase "your reward for eating", since I am not a native speaker. ;)

In D25358#618886, @gbe wrote:
In D25358#618885, @imp wrote:
In D25358#618884, @gbe wrote:

@emaste any change that this can be committed before the switch to git?

Nope. It will have to wait. Your reward for eating, though, is that I'd be happy to do the import to test the process for real once things open again.

OK, even if I don't understand the phrase "your reward for eating", since I am not a native speaker. ;)

Waiting. Your reward for waiting. I can't type this morning.

Sorry this fell off my list, I will put it at the top of my post-git list if @imp doesn't get to it first.

Sorry this fell off my list, I will put it at the top of my post-git list if @imp doesn't get to it first.

No worries, Christmas is a head and new years eve is on the horizon! I just don't like to work on new things, when the old things are still not finished.

--Gordon

Ping? That is somewhat getting something discourage further work for FreeBSD!

Doh! My brains have been fried for the last two months and this dropped on the floor. I'll take care of it tonight.

Has this change been committed yet?

In D25358#675151, @bcr wrote:

Has this change been committed yet?

Not to my knowledge.