Page MenuHomeFreeBSD
Differential D25242

vis(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Jun 12 2020, 7:26 AM.
Tags
None
Referenced Files
F106189082: D25242.diff
Thu, Dec 26, 8:56 PM
Unknown Object (File)
Tue, Dec 10, 2:06 AM
Unknown Object (File)
Sat, Nov 30, 3:24 AM
Unknown Object (File)
Sat, Nov 30, 3:24 AM
Unknown Object (File)
Wed, Nov 27, 3:52 AM
Unknown Object (File)
Wed, Nov 27, 3:34 AM
Unknown Object (File)
Nov 18 2024, 1:36 PM
Unknown Object (File)
Nov 9 2024, 4:18 PM
View All 65 Files
Subscribers
bcr
gbe
imp
Contributor Reviews (src)

Details

Reviewers
bcr
imp
Group Reviewers
manpages
Commits
rGcee8be2c78f1: vis(1): Add EXAMPLES section
Summary
  • Add three examples showing the use of -h, -l, -t, -w

Sorry, this is a tricky one to review due to all the double scapes and such.

Test Plan
  • mandoc -Tlint clean
  • igor clean except for the use of "don't" in line 91. I do not know the policy for contractions.
  • aspell happy
  • man ./vis.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31655
Build 29234: arc lint + arc unit

Event Timeline

fernape created this revision.Jun 12 2020, 7:26 AM
Herald added a reviewer: manpages. · View Herald TranscriptJun 12 2020, 7:26 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
Harbormaster completed remote builds in B31655: Diff 73008.Jun 12 2020, 7:26 AM
fernape requested review of this revision.Jun 12 2020, 7:26 AM
gbe added a subscriber: gbe.Jun 12 2020, 8:05 AM
gbe added a comment.Jun 12 2020, 8:09 AM

I have an open differential https://reviews.freebsd.org/D23893 which synchronizes NetBSD changes with our version. Maybe our efforts can be joined. Could you try to integrate my differential first and then apply your manpage updates upon it?

gbe mentioned this in D23893: Sync vis(1) with NetBSD.Jun 12 2020, 8:12 AM
fernape added a comment.Jun 12 2020, 10:55 AM
In D25242#556485, @gbe wrote:

I have an open differential https://reviews.freebsd.org/D23893 which synchronizes NetBSD changes with our version. Maybe our efforts can be joined. Could you try to integrate my differential first and then apply your manpage updates upon it?

Sure thing, I can try later today. Where would the merge be updated? In this review (D25242) or in yours (D23893)?

gbe added a comment.Jun 13 2020, 6:51 AM

Once https://reviews.freebsd.org/D23893 is committed you just have to rebase your differential. So we have the new examples section with the latest version of VIS. And after the commit, don't forget the sending your diff to the NetBSD folks. :)

fernape added a comment.Jun 13 2020, 4:01 PM
In D25242#556821, @gbe wrote:

Once https://reviews.freebsd.org/D23893 is committed you just have to rebase your differential. So we have the new examples section with the latest version of VIS. And after the commit, don't forget the sending your diff to the NetBSD folks. :)

OK.

Note I'm not an src or docs committer though, I would need this review approved first ;-)

bcr accepted this revision as: bcr.Jul 16 2020, 2:01 PM
bcr added a subscriber: bcr.

Looks good, sorry for the delay.

This revision is now accepted and ready to land.Jul 16 2020, 2:01 PM
fernape added a comment.Jul 21 2020, 4:51 PM
In D25242#568441, @bcr wrote:

Looks good, sorry for the delay.

No worries, thanks a lot for reviewing. I'm waiting for D25358 to be committed first, though.

gbe added a comment.Feb 17 2021, 4:59 PM

@imp would you approve this as direct commit to contrib?

There is still https://reviews.freebsd.org/D25358 pending for a vendor import, but these examples are a good addition for the man page.

imp accepted this revision.Feb 17 2021, 11:01 PM

Looks reasonable, Shouldn't cause too much grief for merging from the successors of our former upstream...

gbe accepted this revision as: manpages.Feb 18 2021, 5:01 PM

LGTM

@fernape please forward this diff to christos@netbsd.org if you have some time.

Closed by commit rGcee8be2c78f1: vis(1): Add EXAMPLES section (authored by fernape). · Explain WhyFeb 18 2021, 6:15 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rGcee8be2c78f1: vis(1): Add EXAMPLES section.
fernape added a comment.Feb 18 2021, 6:15 PM

Thanks!

Revision Contents
Changeset List

PathSize
contrib/
vis/
19 lines

Diff 73008

View Options

contrib/vis/vis.1

Loading...