Track switch to libinput in xorg-server 1.20.8:
ClosedPublic
Actions

Authored by pauamma_gundo.com on Jul 13 2020, 5:08 AM.

Details

Reviewers

bcr
carlavilla
0mp

Group Reviewers

docs
x11

Commits

rD54421: Track switch to libinput in xorg-server 1.20.8

Summary

Remove the Driver line from examples 5.7 and 5.9, thus making them valid for both variant configurations of X (with or without libinput).
For 12.1 and xorg-server 1.20.8, add "Set kern.evdev.rcpt_mask=6 in /etc/sysctl.conf if not using moused" important paragraph to section "5.4.7.2. Mice and Pointing Devices".

PR 244820

Note 1: I removed the "XkbVariant" line because I don't have access to
that keyboard layout to test. Anyone who does is welcome to test and
ask me to keep that variant.

Note 2: This configuration change needs more testing than I can
provide, including from people using hotpluggable keyboards and or
mice.

Test Plan

Tested with lynx, checked with igor (modified section only).

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pauamma_gundo.com requested review of this revision.Jul 13 2020, 5:08 AM

pauamma_gundo.com created this revision.

Harbormaster completed remote builds in B32283: Diff 74382.Jul 13 2020, 5:08 AM

I'll check the changes in my laptop. Thanks!

I tested the changes in my own laptop. But instead of using "fr" I used "es" because it's my locale.
And everything works well.

@bcr can I make the commit? what do you think about this changes?

oh, I forgot about the notes... hmmm... I'll try to test this too, sorry.

Sure, go ahead. Thank you!

This revision is now accepted and ready to land.Jul 21 2020, 9:16 AM

zeising added a subscriber: zeising.Jul 21 2020, 10:22 AM

zeising added inline comments.

en_US.ISO8859-1/books/handbook/x11/chapter.xml
878–885 ↗	(On Diff #74382)	This is only partially true. First off, I'd prefer if we suggest setting kern.evdev.rcpt_mask=12. This is already the default on FreeBSD 12-STABLE and 13-CURRENT, and is only needed on 12.1-RELEASE. In general, there should not be any need for moused at all, and having libinput taking care of mosue things when running X is a good thing.

@pauamma_gundo.com can you please take a look at the @zeising comments?

In D25641#570890, @carlavilla wrote:

@pauamma_gundo.com can you please take a look at the @zeising comments?

Replied, will try to address the change request tonight.

en_US.ISO8859-1/books/handbook/x11/chapter.xml
878–885 ↗	(On Diff #74382)	Noted re s/6/12/, will do that when I have a moment. (Probably tonight.) Re use of moused, https://www.freebsd.org/doc/en_US.ISO8859-1/books/faq/x.html#x-and-moused still mentions use cases for it and I'm reluctant to remove all mentions of that use case unless that FAQ is changed first.

Change mask from 6 to 12 per zeising's request.

This revision now requires review to proceed.Jul 24 2020, 11:12 PM

Harbormaster completed remote builds in B32533: Diff 74901.Jul 24 2020, 11:12 PM

pauamma_gundo.com marked an inline comment as done.Jul 24 2020, 11:13 PM

zeising added inline comments.Jul 29 2020, 3:34 PM

en_US.ISO8859-1/books/handbook/x11/chapter.xml
878–885 ↗	(On Diff #74382)	Noted re s/6/12/, will do that when I have a moment. (Probably tonight.) Re use of moused, https://www.freebsd.org/doc/en_US.ISO8859-1/books/faq/x.html#x-and-moused still mentions use cases for it and I'm reluctant to remove all mentions of that use case unless that FAQ is changed first. Those entries are quite old, and quite wrong, and should probably be updated or removed.