Page MenuHomeFreeBSD

time(1): Add EXAMPLES section
AbandonedPublic

Authored by fernape on Jul 2 2020, 4:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 7:51 AM
Unknown Object (File)
Nov 15 2023, 9:20 PM
Unknown Object (File)
Nov 14 2023, 7:11 PM
Unknown Object (File)
Oct 31 2023, 4:17 AM
Unknown Object (File)
Oct 16 2023, 3:57 AM
Unknown Object (File)
Oct 14 2023, 8:21 PM
Unknown Object (File)
Oct 13 2023, 6:12 PM
Unknown Object (File)
Sep 15 2023, 11:39 AM

Details

Reviewers
bcr
Group Reviewers
manpages
Summary
  • Add EXAMPLES showing all five flags: -a, -h, -l, -o, -p
  • Not updating .Dd deliberately
Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./time.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32122
Build 29633: arc lint + arc unit

Event Timeline

Some suggestions for improvement...

usr.bin/time/time.1
137

You're using the shell built-in time here versus the one in /usr/bin/time below. Is that intended?

151

Maybe we can find a different example that does not give 0 as result in both cases.
How about a copy operation, for example an ISO file or a backup of some sort. The second time the command is repeated, the effects of caching should result in a much faster execution time.

Address comments by bcr@:

  • Execute time(1) instead of shell builtin
  • Use an example that shows some non-zero times
fernape added inline comments.
usr.bin/time/time.1
137

Arrrg. That was a mistake. Sorry.

151

I don't get a big difference, maybe because the bootonly iso is not so big, but I think it is clearer now. Thanks!

Looks good to me now, although I would use amd64 in the example as i386 is going the way of the dodo. But it does not matter much for the example.

This revision is now accepted and ready to land.Jul 3 2020, 1:31 PM
fernape marked 2 inline comments as done.

s/i386/amd64/g as suggested by bcr@

This revision now requires review to proceed.Jul 3 2020, 5:55 PM
In D25548#564975, @bcr wrote:

Looks good to me now, although I would use amd64 in the example as i386 is going the way of the dodo. But it does not matter much for the example.

Done in https://svnweb.freebsd.org/base?view=revision&revision=362992

Thanks for reviewing this!

Abandoning revision since it is committed and Phabricator does not give me the option of just closing it.

@fernape that's because you have forgotten the differential version in the commit message, please also include a 'reviewed by' in future commits.

In D25548#565873, @gbe wrote:

@fernape that's because you have forgotten the differential version in the commit message, please also include a 'reviewed by' in future commits.

Sorry, for that. I sent a follow up email