Page MenuHomeFreeBSD
Differential D25342

cmp(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Jun 18 2020, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 12:55 AM
Unknown Object (File)
Oct 4 2023, 6:15 AM
Unknown Object (File)
Jul 31 2023, 11:37 PM
Unknown Object (File)
Jun 5 2023, 8:05 AM
Unknown Object (File)
Jun 3 2023, 8:17 AM
Unknown Object (File)
May 14 2023, 6:53 PM
Unknown Object (File)
Dec 11 2022, 7:14 PM
Subscribers
0mp
bcr
imp
Contributor Reviews (src)

Details

Reviewers
0mp
Group Reviewers
manpages
Summary

Add a small number of examples depicting the use of -l, -z and byte offsets

Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./cmp.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31831
Build 29391: arc lint + arc unit

Event Timeline

fernape created this revision.Jun 18 2020, 4:28 PM
Herald added a reviewer: manpages. · View Herald TranscriptJun 18 2020, 4:28 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Jun 18 2020, 4:28 PM
Harbormaster completed remote builds in B31801: Diff 73278.Jun 18 2020, 4:28 PM
bcr accepted this revision as: manpages.Jun 18 2020, 5:59 PM
bcr added a subscriber: bcr.

Alright, good to go.

0mp requested changes to this revision.Jun 18 2020, 7:24 PM
0mp added a subscriber: 0mp.
0mp added inline comments.
usr.bin/cmp/cmp.1
125

I am not sure but maybe a change in the third byte of stdin would sound better.

136

How about Compare file sizes of A and B and return 1 if they are not equal.

147

Shouldn't it be the first 4 bytes and the first 2 bytes instead?

This revision now requires changes to proceed.Jun 18 2020, 7:24 PM
fernape updated this revision to Diff 73340.Jun 19 2020, 4:13 PM

Addressing comments by 0mp@:

  • Rephrasing example descriptions
Harbormaster completed remote builds in B31831: Diff 73340.Jun 19 2020, 4:13 PM
fernape marked 3 inline comments as done.Jun 19 2020, 4:14 PM
0mp accepted this revision.Jun 19 2020, 4:32 PM

LGTM!

This revision is now accepted and ready to land.Jun 19 2020, 4:32 PM
fernape closed this revision.Jun 20 2020, 11:29 AM

Done in r362434

Thanks for reviewing!

Revision Contents
Changeset List

PathSize
usr.bin/
cmp/
21 lines

Diff 73340

View Options

usr.bin/cmp/cmp.1

Loading...