Page MenuHomeFreeBSD

ipfirewall.4: restructure new line starts and remove .Tn
Needs ReviewPublic

Authored by driesm.michiels_gmail.com on Fri, May 22, 9:35 AM.

Details

Reviewers
bcr
rgrimes
0mp
Group Reviewers
manpages
Summary

This diff restructures some of the enters used in sentences as well as remove the .Tn's as discussed.

MFC with r361355

Test Plan

mandoc ipfirewall.4

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 31237
Build 28886: arc lint + arc unit

Event Timeline

driesm.michiels_gmail.com requested review of this revision.Fri, May 22, 9:35 AM
rgrimes requested changes to this revision.Fri, May 22, 2:06 PM

Just a couple nits, and I can be ignore on my line breaking issues.

share/man/man4/ipfirewall.4
18

I usually leave sentences line broken and points like and/or/which/when/.... there is actual a very old groff style guide that recommends this.

65–66

as a NAT facility reads slight clearer for me, start a new line at "the kernel option"

This revision now requires changes to proceed.Fri, May 22, 2:06 PM
driesm.michiels_gmail.com planned changes to this revision.Fri, May 22, 3:23 PM

Just for my understanding before I start making changes

share/man/man4/ipfirewall.4
18

So would that be:

..... which \n
or

... \n
which

rgrimes added inline comments.Fri, May 22, 3:41 PM
share/man/man4/ipfirewall.4
18

Just put it back how it was, as in no change needed here.

Yea NP, there are a lot of other “which”s that dont start on a new line, I could move those to get consitency?

No, the point was to reduce the amount of change

driesm.michiels_gmail.com updated this revision to Diff 72118.EditedFri, May 22, 4:13 PM

incorporate feedback

driesm.michiels_gmail.com marked 3 inline comments as done.Fri, May 22, 4:13 PM