Page MenuHomeFreeBSD

[linux-emulation and nanobsd] some hugo/asciidoctor changes
Needs RevisionPublic

Authored by carlavilla on Sat, Jun 27, 5:36 PM.

Details

Reviewers
bcr
imp
hrs
Summary

In the linux-emulation article:

change the .... separator to ... -> this change doesn't affect the purpose of the example
Test Plan

Compile the articles

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

carlavilla requested review of this revision.Sat, Jun 27, 5:36 PM
carlavilla created this revision.
bcr added a reviewer: imp.Sat, Jun 27, 6:13 PM

Adding Warner for comments on nanoBSD. I see no problems with these changes personally.

imp requested changes to this revision.Sun, Jun 28, 3:28 AM

All the nanobsd changes are wrong.

en_US.ISO8859-1/articles/nanobsd/article.xml
170 ↗(On Diff #73781)

The original was correct. It is an_ not a - here and below

This revision now requires changes to proceed.Sun, Jun 28, 3:28 AM

@imp yes, I know that the original number have the _ character instead the - character.

But AsciiDoctor uses the _ character to put the word in italic.

But if the change it's wrong don't worry I'll find another way. Thanks.

carlavilla updated this revision to Diff 73799.Sun, Jun 28, 7:05 AM
carlavilla edited the summary of this revision. (Show Details)

NanoBSD changes deleted

@imp and @bcr can you please review the new diff again.
Thanks :)

I added @hrs to the review.

bcr added a comment.Sun, Jun 28, 9:51 AM

I get this exception when I load this review in Phabricator:

Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file

Not sure what's going on, maybe you need to re-do the diff and upload it again?

bcr accepted this revision.Sun, Jun 28, 9:52 AM

Now the error went away... Strange, maybe a Phabricator hiccup. Anyway, this change is easy and hereby approved!

imp added a comment.Sun, Jun 28, 9:54 AM

@imp and @bcr can you please review the new diff again.
Thanks :)

New stuff looks good to me.

Is there some quoting needed for NanoBSD's funky names we can do instead?

carlavilla added a comment.EditedMon, Jun 29, 11:24 AM

I don't know how I couldn't remember ... you just have to escape the character, instead of _ use \_

@hrs and @imp can you add your approval to the review?

Thanks for your time all of you!

imp accepted this revision.Mon, Jun 29, 2:36 PM

Current changes are good.

This revision is now accepted and ready to land.Mon, Jun 29, 2:36 PM
imp added a comment.Mon, Jun 29, 2:37 PM

I don't know how I couldn't remember ... you just have to escape the character, instead of _ use \_

Cool. Are you doing that?

In D25492#563586, @imp wrote:

I don't know how I couldn't remember ... you just have to escape the character, instead of _ use \_

Cool. Are you doing that?

Yes, I'm using this and works well. This week I'm going to show all the articles converted to Hugo/AsciiDoctor and the next week I'll start with the books :)

bcr added a comment.Mon, Jun 29, 5:27 PM
In D25492#563586, @imp wrote:

I don't know how I couldn't remember ... you just have to escape the character, instead of _ use \_

Cool. Are you doing that?

Yes, I'm using this and works well. This week I'm going to show all the articles converted to Hugo/AsciiDoctor and the next week I'll start with the books :)

I like that very much!

hrs requested changes to this revision.Mon, Jun 29, 6:17 PM

Please use … instead of three periods. It is the correct way to show a horizontal ellipsis.

This revision now requires changes to proceed.Mon, Jun 29, 6:17 PM