This update to rootgen.sh and install-boot.sh covers most all boot cases: amd64{geli,nogeli}-{gpt,mbr}-{ufs,zfs}-{legacy,uefi,both}

Updated with removed cruft

Update to also not decrypt the left over bits of partial 4k sectors

In D15847#335079, @imp wrote:

I'm leery of committing 'I'm not sure why, but this seems to make it work' kind of code.

On the other hand, Ian cleans up this part of the code a lot so maybe it's not a big deal and we'll just use his cleanup when it's ready. He wants testability, and this will further that need.

In D15844#335074, @imp wrote:

Are there other disks that we should give this treatment to? Like all of them?

Update this now that all supported versions of FreeBSD can adjust the ARC at runtime

Create the ZSTD replication feature flag

• Set for both -c (compressed send) and -e (embedded blocks)

It seems to make it would make more sense to steal 1 character each from 'SIZE' and 'RES' by fixing the humanizing, so that values such as '38836K' and printed as '38M', and we know we'll never exceed 5 characters. I see value in doing 9216K instead of 9M, but once you are into 5 digits, it makes sense to go up the units scale.

Why would you reduce the username field from 13-15 down to 8 characters? There are plenty of usernames of 8-12+ characters on my systems

Add a 'zfs send' feature flag, to indicate that zstd is required to receive this stream

Don't forget to update the dates on the man pages

In D7734#333080, @jonathan wrote:

So... should this revision be abandoned in favour of an approach that uses the new enable_sandbox_{basic,full}() functions?

Adding range support for holds and bookmarks has been on my todo list for a while now.

This is much cleaner. Thank you for putting in the effort.

Additional fixes:

• make qemu .sh files not get overwritten in _both() cases
• copy more bootcode files to the target directory so installboot.sh can find them

Update to r334532

Address feedback from rgrimes@, melifaro@, and everyone else who commented

After discussion with rgrimes, round needed up to the nearest full PAGE_SIZE

Add support for zstd compression levels to ZFS channel programs

Nicely done. Thank you

the "new" nvme_print_controller() function appears to be missing from your diff. Missing a file?

It might not make sense here, since it would reduce the available space for randomization, but just as a note, the FreeBSD Project has its own OUI space: 58:9C:FC:??:??:??

C for check, makes sense to me since n is used in a different context already.

Yeah, if we can do the native version that is better, and it means the license is standard MPL

Fix alignment of the cpu header

Thanks for working on this

Coverity found a number of issues with this commit. It is possible they are false positives:

Rebase to r331496

Update to r329600

In D14517#304347, @emaste wrote:

We should probably put 'doc' back in the list, there's no fundamental reason docs shouldn't be installed in a jail, perhaps a follow-up after further investigation.

Fix tense error pointed out by bcr

This looks pretty clean, I like it.

For this to work right, shouldn't we load /etc/rc.conf.d/pf and maybe ipf as well?

This seems like a much safer approach