Page MenuHomeFreeBSD

Make camcontrol identify work with nda devices
ClosedPublic

Authored by imp on May 9 2018, 7:56 PM.
Tags
None
Referenced Files
F132465831: D15371.id42329.diff
Fri, Oct 17, 4:12 AM
Unknown Object (File)
Thu, Oct 16, 3:35 AM
Unknown Object (File)
Sat, Sep 27, 1:23 AM
Unknown Object (File)
Aug 3 2025, 4:50 AM
Unknown Object (File)
Aug 2 2025, 12:56 AM
Unknown Object (File)
Jun 30 2025, 2:45 PM
Unknown Object (File)
Jun 25 2025, 4:56 AM
Unknown Object (File)
Jun 22 2025, 11:07 PM
Subscribers

Details

Summary

Make it possible to use print_controller from another program

Rename print_controller to nvme_print_controller. Put it in its
own file for easy inclusion. Move util.c to be nc_util.c to not
conflict with camcontrol. add nvecontrol_ext.h to define shared
interfaces.

Both ATA and NVME have an identify command. They are completely
different, but to the user they are the same. Leverage nvmecontrol's
print_controller code to provide that functionality to camcontrol
identify. Query the path to see what kind of protocol it supports, and
send the most appropriate command down. Refactor nvme_print_dev a
little to make it easy to get the nvme cdata.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

the "new" nvme_print_controller() function appears to be missing from your diff. Missing a file?

This revision is now accepted and ready to land.May 9 2018, 8:26 PM
This revision was automatically updated to reflect the committed changes.