Page MenuHomeFreeBSD

Make camcontrol identify work with nda devices

Authored by imp on May 9 2018, 7:56 PM.



Make it possible to use print_controller from another program

Rename print_controller to nvme_print_controller. Put it in its
own file for easy inclusion. Move util.c to be nc_util.c to not
conflict with camcontrol. add nvecontrol_ext.h to define shared

Both ATA and NVME have an identify command. They are completely
different, but to the user they are the same. Leverage nvmecontrol's
print_controller code to provide that functionality to camcontrol
identify. Query the path to see what kind of protocol it supports, and
send the most appropriate command down. Refactor nvme_print_dev a
little to make it easy to get the nvme cdata.

Sponsored by: Netflix

Diff Detail

rS FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp created this revision.May 9 2018, 7:56 PM

the "new" nvme_print_controller() function appears to be missing from your diff. Missing a file?

imp updated this revision to Diff 42329.May 9 2018, 8:22 PM

Mroe stuff?

allanjude accepted this revision.May 9 2018, 8:26 PM

Nicely done. Thank you

This revision is now accepted and ready to land.May 9 2018, 8:26 PM
This revision was automatically updated to reflect the committed changes.