Update the version
Remove old conflict (komodo-edit 6 is no longer a concern)
Remove the restricted flag, the current license is mozilla-like and
allows redistribution
Details
Details
- Reviewers
jrm mmokhi - Commits
- rP468357: editors/komodo-edit: Update to version 11.0.2
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
looks good to me :)
gonna do a quick check as well :)
| editors/komodo-edit/Makefile | ||
|---|---|---|
| 1 ↗ | (On Diff #41673) | I was to remove all of "Created by:" flags from the ports I created and I'm maintaining, I was told it's not necessary because portmgr@ will do it once for all when it becomes necessary. |
Comment Actions
I only have a few moments, so here are a few quick, nit-picky changes to conform to the Porter's Handbook.
- replace all instances of PORTVERSION with DISTVERSION
- set LICENSE
- Sort everything after COMMENT=.. according to the Order of Variables in Port Makefiles chapter in the Porter's Handbook.
I'll be back in a few hours and can test.
Comment Actions
I did a few run-time tests and I see a few errors, but it still starts and after playing for a few minutes it seems functional.
Fontconfig error: "/etc/fonts/conf.d/10-scale-bitmap-fonts.conf", line 72: non-double matrix element Fontconfig error: "/etc/fonts/conf.d/10-scale-bitmap-fonts.conf", line 72: non-double matrix element Fontconfig warning: "/etc/fonts/conf.d/10-scale-bitmap-fonts.conf", line 80: saw unknown, expected number 1524233444045 addons.xpi WARN Exception running bootstrap method install on check-compatibility@dactyl.googlecode.com: TypeError: Unknown preference type: undefined (resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///usr/local/share/komodo-edit/lib/mozilla/extensions/check-compatibility@dactyl.googlecode.com.xpi!/bootstrap.js:169:18) JS Stack trace: set@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///usr/local/share/komodo-edit/lib/mozilla/extensions/check-compatibility@bootstrap.js:169:19 < install@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///usr/local/share/komodo-edit/lib/mozilla/extensions/check-compatibility@bootstrap.js:56:9 < install@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///usr/local/share/komodo-edit/lib/mozilla/extensions/check-compatibility@bootstrap.js:212:9 < XPI_callBootstrapMethod@XPIProvider.jsm:4436:9 < addMetadata@XPIProvider.jsm:3332:1 < XPI_processFileChanges@XPIProvider.jsm:3441:23 < XPI_checkForChanges@XPIProvider.jsm:3602:34 < XPI_startup@XPIProvider.jsm:2090:25 < callProvider@AddonManager.jsm:208:12 < _startProvider@AddonManager.jsm:667:5 < AMI_startup@AddonManager.jsm:821:9 < AMP_startup@AddonManager.jsm:2399:5 < AMC_observe@addonManager.js:55:7 LoadPlugin: failed to initialize shared library libXt.so [libXt.so: cannot open shared object file: No such file or directory] LoadPlugin: failed to initialize shared library libXext.so [libXext.so: cannot open shared object file: No such file or directory] LoadPlugin: failed to initialize shared library /usr/home/jrm/.mozilla/plugins/npwrapper.libflashplayer.so [/usr/home/jrm/.mozilla/plugins/npwrapper.libflashplayer.so: wrong ELF class: ELFCLASS64] SciMoz was not closed correctly before destructor called. SciMoz was not closed correctly before destructor called.
Comment Actions
editors/komodo-edit: Update to version 11.0.2
Also
- add license information
TODO:
- fix fontconfig error (looking for fonts in /etc/fonts)
- fix error with codeintel, which fails to start
- build native version?
Submitted by: allanjude (maintainer)
Reviewed by: mmokhi
Differential Revision: https://reviews.freebsd.org/D15140
Comment Actions
Yeah, if we can do the native version that is better, and it means the license is standard MPL