Correct logic error
ClosedPublic
Actions

Authored by allanjude on Jun 16 2018, 1:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 20 2023, 6:27 AM

	Unknown Object (File)
	Aug 22 2023, 3:59 PM

	Unknown Object (File)
	Aug 13 2023, 6:14 AM

	Unknown Object (File)
	Aug 2 2023, 6:06 PM

	Unknown Object (File)
	May 8 2023, 10:03 AM

	Unknown Object (File)
	May 8 2023, 10:03 AM

	Unknown Object (File)
	May 8 2023, 9:44 AM

	Unknown Object (File)
	Apr 13 2023, 4:20 PM

Subscribers

None

Details

Reviewers

imp
tsoome
kevans
• ian

Commits

rS335245: Correct logic error in biosdisk.c:bd_realstrategy()

Summary

While investigating an issue with GELI boot, I found what looks like a logic error. The contents of the if statement are definately meant to run if disk_ioctl successed, but actually only run if it fails. This also results in the 'We should not get here' code running in most cases