Correct logic error
ClosedPublic
Actions

Authored by allanjude on Jun 16 2018, 1:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Nov 24 2024, 12:52 PM

	Unknown Object (File)
	Oct 3 2024, 3:58 PM

	Unknown Object (File)
	Sep 27 2024, 8:35 AM

	Unknown Object (File)
	Sep 17 2024, 10:13 AM

	Unknown Object (File)
	Sep 8 2024, 12:50 PM

	Unknown Object (File)
	Sep 7 2024, 10:53 PM

	Unknown Object (File)
	Sep 7 2024, 9:04 AM

	Unknown Object (File)
	Sep 7 2024, 6:05 AM

View All 23 Files

Subscribers

None

Details

Reviewers

imp
tsoome
kevans
• ian

Commits

rS335245: Correct logic error in biosdisk.c:bd_realstrategy()

Summary

While investigating an issue with GELI boot, I found what looks like a logic error. The contents of the if statement are definately meant to run if disk_ioctl successed, but actually only run if it fails. This also results in the 'We should not get here' code running in most cases