calloc() macros to stdlib.h.
ClosedPublic
Actions

Authored by markj on Feb 13 2018, 3:57 PM.

Details

Reviewers

cem
allanjude
imp
bapt

Commits

rS329238: Move zstd malloc()/free()/calloc() macros to stdlib.h.

Summary

The issue with keeping them in the main compat header is that the macro
definitions leak into anything that includes zstd.h, which might include
native FreeBSD code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Feb 13 2018, 3:57 PM

Harbormaster completed remote builds in B15010: Diff 39255.Feb 13 2018, 3:57 PM

markj added reviewers: cem, allanjude, imp, bapt.Feb 13 2018, 4:00 PM

allanjude accepted this revision.Feb 13 2018, 4:33 PM

This revision is now accepted and ready to land.Feb 13 2018, 4:33 PM

cem accepted this revision.Feb 13 2018, 5:13 PM

this looks fine, apart maybe from the copyright stuff...

But honestly, those few lines are likely not deserving of copyright protection...

sys/contrib/zstd/lib/freebsd/stdlib.h
2 ↗	(On Diff #39255)	2015?

In D14352#300773, @imp wrote:

this looks fine, apart maybe from the copyright stuff...

But honestly, those few lines are likely not deserving of copyright protection...

I didn't really think so either, but it doesn't hurt to be conservative here.

sys/contrib/zstd/lib/freebsd/stdlib.h
2 ↗	(On Diff #39255)	I just copied it from zstd_kfreebsd.h.

imp accepted this revision.Feb 13 2018, 5:57 PM

imp added inline comments.

sys/contrib/zstd/lib/freebsd/stdlib.h
2 ↗	(On Diff #39255)	Fair enough.

Closed by commit rS329238: Move zstd malloc()/free()/calloc() macros to stdlib.h. (authored by markj). · Explain WhyFeb 13 2018, 7:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

contrib/

zstd/

lib/

freebsd/

stdlib.h

47 lines

zstd_kfreebsd.h

8 lines

Diff 39265

View Options

head/sys/contrib/zstd/lib/freebsd/stdlib.h